* RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
@ 2015-12-18 9:52 Thomas Preud'homme
2015-12-18 18:23 ` Joel Brobecker
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Preud'homme @ 2015-12-18 9:52 UTC (permalink / raw)
To: gdb-patches
[Reworded title to make the intent of this patch hopefully clearer]
Ping?
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Thomas Preud'homme
> Sent: Friday, December 04, 2015 1:58 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] Add expect for when using CLI jump to run a cmd in
> testsuite
>
> Hi,
>
> Currently, mi_run_cmd_full have no expect for the case where CLI jump
> is used to run a command. This cause subsequent expects to get
> occasionally confused at the output they receive, depending on the
> interleaving of the CLI jump and following commands. This makes
> tracking regressions in gdb more painful because of all the test results flip
> flop. This patch fixes the issue by adding the necessary expect.
>
> ChangeLog entry is as follows:
>
> 2015-10-15 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the CLI
> jump
> case.
>
>
> diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> support.exp
> index 0d17ecb..cc055f6 100644
> --- a/gdb/testsuite/lib/mi-support.exp
> +++ b/gdb/testsuite/lib/mi-support.exp
> @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
> # to better handle RUN.
> send_gdb "jump *$start\n"
> warning "Using CLI jump command, expect run-to-main FAIL"
> + gdb_expect {
> + -re "${run_match}&\"jump
> \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> + }
> return 0
> }
>
>
> With this patch applied, testsuite results become much more stable.
>
> Is this ok for the master branch?
>
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH, ping1] Add missing expect for running a program with CLI jump
2015-12-18 9:52 [PATCH, ping1] Add missing expect for running a program with CLI jump Thomas Preud'homme
@ 2015-12-18 18:23 ` Joel Brobecker
2015-12-21 10:20 ` Thomas Preud'homme
0 siblings, 1 reply; 5+ messages in thread
From: Joel Brobecker @ 2015-12-18 18:23 UTC (permalink / raw)
To: Thomas Preud'homme; +Cc: gdb-patches
> > 2015-10-15 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the CLI
> > jump
> > case.
I think the patch is good, but your mailer did some line folding.
Can you resend?
Thanks!
> >
> >
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> > support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
> > # to better handle RUN.
> > send_gdb "jump *$start\n"
> > warning "Using CLI jump command, expect run-to-main FAIL"
> > + gdb_expect {
> > + -re "${run_match}&\"jump
> > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > + }
> > return 0
> > }
> >
> >
> > With this patch applied, testsuite results become much more stable.
> >
> > Is this ok for the master branch?
> >
> > Best regards,
> >
> > Thomas
> >
>
--
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
2015-12-18 18:23 ` Joel Brobecker
@ 2015-12-21 10:20 ` Thomas Preud'homme
2015-12-21 11:06 ` Joel Brobecker
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Preud'homme @ 2015-12-21 10:20 UTC (permalink / raw)
To: 'Joel Brobecker'; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]
Hi Joel,
I hope this time it's fine. I'm also adding it in attachment just in case.
Best regards,
Thomas
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index 0d17ecb..cc055f6 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
# to better handle RUN.
send_gdb "jump *$start\n"
warning "Using CLI jump command, expect run-to-main FAIL"
+ gdb_expect {
+ -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
+ }
return 0
}
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Joel Brobecker
> Sent: Saturday, December 19, 2015 2:23 AM
> To: Thomas Preud'homme
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH, ping1] Add missing expect for running a program
> with CLI jump
>
> > > 2015-10-15 Thomas Preud'homme
> <thomas.preudhomme@arm.com>
> > >
> > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the
> CLI
> > > jump
> > > case.
>
> I think the patch is good, but your mailer did some line folding.
> Can you resend?
>
> Thanks!
>
> > >
> > >
> > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> > > support.exp
> > > index 0d17ecb..cc055f6 100644
> > > --- a/gdb/testsuite/lib/mi-support.exp
> > > +++ b/gdb/testsuite/lib/mi-support.exp
> > > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command
> args} {
> > > # to better handle RUN.
> > > send_gdb "jump *$start\n"
> > > warning "Using CLI jump command, expect run-to-main FAIL"
> > > + gdb_expect {
> > > + -re "${run_match}&\"jump
> > > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> > > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> > > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > > + }
> > > return 0
> > > }
> > >
> > >
> > > With this patch applied, testsuite results become much more stable.
> > >
> > > Is this ok for the master branch?
> > >
> > > Best regards,
> > >
> > > Thomas
> > >
> >
>
> --
> Joel
[-- Attachment #2: gdb-runto-expect.patch --]
[-- Type: application/octet-stream, Size: 602 bytes --]
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index 0d17ecb..cc055f6 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
# to better handle RUN.
send_gdb "jump *$start\n"
warning "Using CLI jump command, expect run-to-main FAIL"
+ gdb_expect {
+ -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
+ }
return 0
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH, ping1] Add missing expect for running a program with CLI jump
2015-12-21 10:20 ` Thomas Preud'homme
@ 2015-12-21 11:06 ` Joel Brobecker
2015-12-22 2:55 ` Thomas Preud'homme
0 siblings, 1 reply; 5+ messages in thread
From: Joel Brobecker @ 2015-12-21 11:06 UTC (permalink / raw)
To: Thomas Preud'homme; +Cc: gdb-patches
> I hope this time it's fine. I'm also adding it in attachment just in case.
>
> Best regards,
>
> Thomas
>
> diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
> index 0d17ecb..cc055f6 100644
> --- a/gdb/testsuite/lib/mi-support.exp
> +++ b/gdb/testsuite/lib/mi-support.exp
> @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
> # to better handle RUN.
> send_gdb "jump *$start\n"
> warning "Using CLI jump command, expect run-to-main FAIL"
> + gdb_expect {
> + -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> + }
> return 0
> }
Thanks. LGTM, so go ahead and push.
> > > > 2015-10-15 Thomas Preud'homme
> > <thomas.preudhomme@arm.com>
> > > >
> > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the
> > CLI
> > > > jump
> > > > case.
> >
> > I think the patch is good, but your mailer did some line folding.
> > Can you resend?
--
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
2015-12-21 11:06 ` Joel Brobecker
@ 2015-12-22 2:55 ` Thomas Preud'homme
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Preud'homme @ 2015-12-22 2:55 UTC (permalink / raw)
To: 'Joel Brobecker'; +Cc: gdb-patches
Done, thanks.
Best regards,
Thomas
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Joel Brobecker
> Sent: Monday, December 21, 2015 7:06 PM
> To: Thomas Preud'homme
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH, ping1] Add missing expect for running a program
> with CLI jump
>
> > I hope this time it's fine. I'm also adding it in attachment just in case.
> >
> > Best regards,
> >
> > Thomas
> >
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args}
> {
> > # to better handle RUN.
> > send_gdb "jump *$start\n"
> > warning "Using CLI jump command, expect run-to-main FAIL"
> > + gdb_expect {
> > + -re "${run_match}&\"jump
> \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > + }
> > return 0
> > }
>
> Thanks. LGTM, so go ahead and push.
>
> > > > > 2015-10-15 Thomas Preud'homme
> > > <thomas.preudhomme@arm.com>
> > > > >
> > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for
> the
> > > CLI
> > > > > jump
> > > > > case.
> > >
> > > I think the patch is good, but your mailer did some line folding.
> > > Can you resend?
> --
> Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-22 2:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 9:52 [PATCH, ping1] Add missing expect for running a program with CLI jump Thomas Preud'homme
2015-12-18 18:23 ` Joel Brobecker
2015-12-21 10:20 ` Thomas Preud'homme
2015-12-21 11:06 ` Joel Brobecker
2015-12-22 2:55 ` Thomas Preud'homme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox