From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61483 invoked by alias); 22 Dec 2015 02:55:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61469 invoked by uid 89); 22 Dec 2015 02:55:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:owner@s, ownersourcewareorg, sk:owners, owner@sourceware.org X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Dec 2015 02:55:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D2F849; Mon, 21 Dec 2015 18:55:16 -0800 (PST) Received: from SHAWIN202 (sha-win-202.asiapac.arm.com [10.164.12.31]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B4603F308; Mon, 21 Dec 2015 18:55:40 -0800 (PST) From: "Thomas Preud'homme" To: "'Joel Brobecker'" Cc: References: <000101d13979$d1e0c610$75a25230$@foss.arm.com> <20151218182252.GF29928@adacore.com> <002a01d13bd9$29442990$7bcc7cb0$@foss.arm.com> <20151221110602.GA5564@adacore.com> In-Reply-To: <20151221110602.GA5564@adacore.com> Subject: RE: [PATCH, ping1] Add missing expect for running a program with CLI jump Date: Tue, 22 Dec 2015 02:55:00 -0000 Message-ID: <003f01d13c64$3f6bca80$be435f80$@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-12/txt/msg00456.txt.bz2 Done, thanks. Best regards, Thomas > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Joel Brobecker > Sent: Monday, December 21, 2015 7:06 PM > To: Thomas Preud'homme > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH, ping1] Add missing expect for running a program > with CLI jump >=20 > > I hope this time it's fine. I'm also adding it in attachment just in ca= se. > > > > Best regards, > > > > Thomas > > > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi- > support.exp > > index 0d17ecb..cc055f6 100644 > > --- a/gdb/testsuite/lib/mi-support.exp > > +++ b/gdb/testsuite/lib/mi-support.exp > > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} > { > > # to better handle RUN. > > send_gdb "jump *$start\n" > > warning "Using CLI jump command, expect run-to-main FAIL" > > + gdb_expect { > > + -re "${run_match}&\"jump > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa- > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread- > id=3D\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > > + } > > return 0 > > } >=20 > Thanks. LGTM, so go ahead and push. >=20 > > > > > 2015-10-15 Thomas Preud'homme > > > > > > > > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for > the > > > CLI > > > > > jump > > > > > case. > > > > > > I think the patch is good, but your mailer did some line folding. > > > Can you resend? > -- > Joel