From: "Thomas Preud'homme" <thomas.preudhomme@foss.arm.com>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
Date: Tue, 22 Dec 2015 02:55:00 -0000 [thread overview]
Message-ID: <003f01d13c64$3f6bca80$be435f80$@foss.arm.com> (raw)
In-Reply-To: <20151221110602.GA5564@adacore.com>
Done, thanks.
Best regards,
Thomas
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Joel Brobecker
> Sent: Monday, December 21, 2015 7:06 PM
> To: Thomas Preud'homme
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH, ping1] Add missing expect for running a program
> with CLI jump
>
> > I hope this time it's fine. I'm also adding it in attachment just in case.
> >
> > Best regards,
> >
> > Thomas
> >
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args}
> {
> > # to better handle RUN.
> > send_gdb "jump *$start\n"
> > warning "Using CLI jump command, expect run-to-main FAIL"
> > + gdb_expect {
> > + -re "${run_match}&\"jump
> \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > + }
> > return 0
> > }
>
> Thanks. LGTM, so go ahead and push.
>
> > > > > 2015-10-15 Thomas Preud'homme
> > > <thomas.preudhomme@arm.com>
> > > > >
> > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for
> the
> > > CLI
> > > > > jump
> > > > > case.
> > >
> > > I think the patch is good, but your mailer did some line folding.
> > > Can you resend?
> --
> Joel
prev parent reply other threads:[~2015-12-22 2:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 9:52 Thomas Preud'homme
2015-12-18 18:23 ` Joel Brobecker
2015-12-21 10:20 ` Thomas Preud'homme
2015-12-21 11:06 ` Joel Brobecker
2015-12-22 2:55 ` Thomas Preud'homme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003f01d13c64$3f6bca80$be435f80$@foss.arm.com' \
--to=thomas.preudhomme@foss.arm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox