From: Joel Brobecker <brobecker@adacore.com>
To: Thomas Preud'homme <thomas.preudhomme@foss.arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, ping1] Add missing expect for running a program with CLI jump
Date: Fri, 18 Dec 2015 18:23:00 -0000 [thread overview]
Message-ID: <20151218182252.GF29928@adacore.com> (raw)
In-Reply-To: <000101d13979$d1e0c610$75a25230$@foss.arm.com>
> > 2015-10-15 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the CLI
> > jump
> > case.
I think the patch is good, but your mailer did some line folding.
Can you resend?
Thanks!
> >
> >
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> > support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
> > # to better handle RUN.
> > send_gdb "jump *$start\n"
> > warning "Using CLI jump command, expect run-to-main FAIL"
> > + gdb_expect {
> > + -re "${run_match}&\"jump
> > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > + }
> > return 0
> > }
> >
> >
> > With this patch applied, testsuite results become much more stable.
> >
> > Is this ok for the master branch?
> >
> > Best regards,
> >
> > Thomas
> >
>
--
Joel
next prev parent reply other threads:[~2015-12-18 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 9:52 Thomas Preud'homme
2015-12-18 18:23 ` Joel Brobecker [this message]
2015-12-21 10:20 ` Thomas Preud'homme
2015-12-21 11:06 ` Joel Brobecker
2015-12-22 2:55 ` Thomas Preud'homme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218182252.GF29928@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=thomas.preudhomme@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox