From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38252 invoked by alias); 18 Dec 2015 09:52:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38230 invoked by uid 89); 18 Dec 2015 09:52:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:owner@s, sk:owners, owner@sourceware.org, ownersourcewareorg X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Dec 2015 09:52:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8BBAD46B for ; Fri, 18 Dec 2015 01:52:09 -0800 (PST) Received: from SHAWIN202 (unknown [10.164.12.31]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A5B3F24D for ; Fri, 18 Dec 2015 01:52:34 -0800 (PST) From: "Thomas Preud'homme" To: Subject: RE: [PATCH, ping1] Add missing expect for running a program with CLI jump Date: Fri, 18 Dec 2015 09:52:00 -0000 Message-ID: <000101d13979$d1e0c610$75a25230$@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-12/txt/msg00357.txt.bz2 [Reworded title to make the intent of this patch hopefully clearer] Ping? > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Thomas Preud'homme > Sent: Friday, December 04, 2015 1:58 PM > To: gdb-patches@sourceware.org > Subject: [PATCH] Add expect for when using CLI jump to run a cmd in > testsuite >=20 > Hi, >=20 > Currently, mi_run_cmd_full have no expect for the case where CLI jump > is used to run a command. This cause subsequent expects to get > occasionally confused at the output they receive, depending on the > interleaving of the CLI jump and following commands. This makes > tracking regressions in gdb more painful because of all the test results = flip > flop. This patch fixes the issue by adding the necessary expect. >=20 > ChangeLog entry is as follows: >=20 > 2015-10-15 Thomas Preud'homme >=20 > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the CLI > jump > case. >=20 >=20 > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi- > support.exp > index 0d17ecb..cc055f6 100644 > --- a/gdb/testsuite/lib/mi-support.exp > +++ b/gdb/testsuite/lib/mi-support.exp > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} { > # to better handle RUN. > send_gdb "jump *$start\n" > warning "Using CLI jump command, expect run-to-main FAIL" > + gdb_expect { > + -re "${run_match}&\"jump > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa- > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread- > id=3D\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > + } > return 0 > } >=20 >=20 > With this patch applied, testsuite results become much more stable. >=20 > Is this ok for the master branch? >=20 > Best regards, >=20 > Thomas >=20