From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64652 invoked by alias); 21 Dec 2015 11:06:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64613 invoked by uid 89); 21 Dec 2015 11:06:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=8866, ping1, Best X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Dec 2015 11:06:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9591811663B; Mon, 21 Dec 2015 06:06:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HR7HwiCmBdI3; Mon, 21 Dec 2015 06:06:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3B4191165A1; Mon, 21 Dec 2015 06:06:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 241ED46BAD; Mon, 21 Dec 2015 15:06:02 +0400 (RET) Date: Mon, 21 Dec 2015 11:06:00 -0000 From: Joel Brobecker To: Thomas Preud'homme Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, ping1] Add missing expect for running a program with CLI jump Message-ID: <20151221110602.GA5564@adacore.com> References: <000101d13979$d1e0c610$75a25230$@foss.arm.com> <20151218182252.GF29928@adacore.com> <002a01d13bd9$29442990$7bcc7cb0$@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <002a01d13bd9$29442990$7bcc7cb0$@foss.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-12/txt/msg00421.txt.bz2 > I hope this time it's fine. I'm also adding it in attachment just in case. > > Best regards, > > Thomas > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp > index 0d17ecb..cc055f6 100644 > --- a/gdb/testsuite/lib/mi-support.exp > +++ b/gdb/testsuite/lib/mi-support.exp > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} { > # to better handle RUN. > send_gdb "jump *$start\n" > warning "Using CLI jump command, expect run-to-main FAIL" > + gdb_expect { > + -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > + } > return 0 > } Thanks. LGTM, so go ahead and push. > > > > 2015-10-15 Thomas Preud'homme > > > > > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the > > CLI > > > > jump > > > > case. > > > > I think the patch is good, but your mailer did some line folding. > > Can you resend? -- Joel