New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

[GDB Administrator]

215a216
> gdb/dwarf2read.c:17927: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,			  struct dwarf2_cu *cu)

Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

[Joel Brobecker]

> > gdb/dwarf2read.c:17927: code: editCase function: Function name starts lower case but has uppercased letters.
> gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,			  struct dwarf2_cu *cu)

Let's add an ARI marker to accept this as a valid exception...

-- 
Joel

RE: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : jeudi 18 avril 2013 17:17
> À : GDB Administrator
> Cc : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-
> gmt
> 
> > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts
> lower case but has uppercased letters.
> > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die,
> struct attribute *attr,			  struct dwarf2_cu *cu)
> 
> Let's add an ARI marker to accept this as a valid exception...
I agree in principle,
but the problem is that to avoid the warning you should add 
/* ARI: editCase */ comment...
And the natural position to insert such comment would 
be after the closing brace of the parameter list.
As you can see above, the function header of get_DW_AT_signature_type is
already
on two lines...

But comments are handled early in gdb_ari.sh gawk script,
as all comments are removed later on.
But this means that it would be difficult to parse multilines
for this ARI comment...

  To put it bluntly,
once again my AWK level is too low to fix this kind of issues...

Pierre Muller
as not-efficient ARI maintainer

Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

[Joel Brobecker]

On Fri, Apr 19, 2013 at 12:19:41AM +0200, Pierre Muller wrote:
> 
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Joel Brobecker
> > Envoyé : jeudi 18 avril 2013 17:17
> > À : GDB Administrator
> > Cc : gdb-patches@sourceware.org
> > Objet : Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-
> > gmt
> > 
> > > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts
> > lower case but has uppercased letters.
> > > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die,
> > struct attribute *attr,			  struct dwarf2_cu *cu)
> > 
> > Let's add an ARI marker to accept this as a valid exception...
> I agree in principle,
> but the problem is that to avoid the warning you should add 
> /* ARI: editCase */ comment...
> And the natural position to insert such comment would 
> be after the closing brace of the parameter list.

I was actually thinking of writing it like so:

    get_DW_AT_signature_type /* ARI: editCase */
      (struct die_info *die, struct attribute *attr,
       struct dwarf2_cu *cu)
    {
    }

Not ideal, but I do not think it would be the first time that
the arguments start on the line following the function name...

-- 
Joel

[commit] Add ARI marker to get_DW_AT_signature_type.

[Joel Brobecker]

Hello,

As discussed at:
http://www.sourceware.org/ml/gdb-patches/2013-04/msg00564.html

gdb/ChangeLog:

        * dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.

Tested by rebuilding GDB. Checked in.

---
 gdb/ChangeLog    |    4 ++++
 gdb/dwarf2read.c |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 630fd1d..429445f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-29  Joel Brobecker  <brobecker@adacore.com>
+
+	* dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.
+
 2013-04-28  Yao Qi  <yao@codesourcery.com>
 
 	* solib-dsbt.c (fetch_loadmap): Re-indent.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 37b7dc4..bd162e6 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *die, ULONGEST signature,
    reading in and processing the type unit if necessary.  */
 
 static struct type *
-get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,
-			  struct dwarf2_cu *cu)
+get_DW_AT_signature_type /* ARI: editCase */
+  (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu)
 {
   /* Yes, DW_AT_signature can use a non-ref_sig8 reference.  */
   if (is_ref_attr (attr))
-- 
1.7.10.4

Re: [commit] Add ARI marker to get_DW_AT_signature_type.

[Joel Brobecker]

> So I would like to propose this patch:
> 
> 
> Pierre Muller as ARI maintainer.
> 
> 
> 2013-04-29  Pierre Muller  <muller@sourceware.org>
> 
>         * dwarf2read.c (handle_DW_AT_stmt_list): Avoid ARI warning for
>         editCase function rule.
>         (get_DW_AT_signature_type): Likewise.

That looks good to me. My patch was based on a misunderstand from
our previous discussion. Note the small typo below, however:

> 
> Index: dwarf2read.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2read.c,v
> retrieving revision 1.790
> diff -u -p -r1.790 dwarf2read.c
> --- dwarf2read.c        29 Apr 2013 05:05:44 -0000      1.790
> +++ dwarf2read.c        29 Apr 2013 08:34:26 -0000
> @@ -8053,7 +8053,7 @@ find_file_and_directory (struct die_info
> 
>  static void
>  handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu,
> -                       const char *comp_dir)
> +                       const char *comp_dir) /ARI: editCase function */
                                               ^^^^ Missing "* " after "/"
>  {
>    struct attribute *attr;
> 
> @@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *di
>     reading in and processing the type unit if necessary.  */
> 
>  static struct type *
> -get_DW_AT_signature_type /* ARI: editCase */
> -  (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu)
> +get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,
> +                         struct dwarf2_cu *cu) /* ARI: editCase function */
>  {
>    /* Yes, DW_AT_signature can use a non-ref_sig8 reference.  */
>    if (is_ref_attr (attr))
> 
> 
> 
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Joel Brobecker
> > Envoyé : lundi 29 avril 2013 07:09
> > À : gdb-patches@sourceware.org
> > Cc : Joel Brobecker
> > Objet : [commit] Add ARI marker to get_DW_AT_signature_type.
> > 
> > Hello,
> > 
> > As discussed at:
> > http://www.sourceware.org/ml/gdb-patches/2013-04/msg00564.html
> > 
> > gdb/ChangeLog:
> > 
> >         * dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.
> > 
> > Tested by rebuilding GDB. Checked in.
> > 
> > ---
> >  gdb/ChangeLog    |    4 ++++
> >  gdb/dwarf2read.c |    4 ++--
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> > index 630fd1d..429445f 100644
> > --- a/gdb/ChangeLog
> > +++ b/gdb/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2013-04-29  Joel Brobecker  <brobecker@adacore.com>
> > +
> > +	* dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.
> > +
> >  2013-04-28  Yao Qi  <yao@codesourcery.com>
> > 
> >  	* solib-dsbt.c (fetch_loadmap): Re-indent.
> > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> > index 37b7dc4..bd162e6 100644
> > --- a/gdb/dwarf2read.c
> > +++ b/gdb/dwarf2read.c
> > @@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *die,
> ULONGEST
> > signature,
> >     reading in and processing the type unit if necessary.  */
> > 
> >  static struct type *
> > -get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,
> > -			  struct dwarf2_cu *cu)
> > +get_DW_AT_signature_type /* ARI: editCase */
> > +  (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu)
> >  {
> >    /* Yes, DW_AT_signature can use a non-ref_sig8 reference.  */
> >    if (is_ref_attr (attr))
> > --
> > 1.7.10.4
> 

-- 
Joel

RE: [commit] Add ARI marker to get_DW_AT_signature_type.

[Pierre Muller]

Hi all,

  Joel,
I commpletely agree with you on the principle of this patch,
but I must confess that it somehow also bypasses the current
implementation of the editCase rule:
  The problem is the following:
if you lok at the patterns for "UCASE function" or "editCase function"
rules,
you will see that possible_editCase is set to one
if and only if there is a function name starting at start of line
followed by an opening brace on the same line...
Which is not the case anymore after your patch...

  The rule is built to be able to find /* ARI: editCase function */
in any of the lines listing all the parameters....
  At least, it is now that I just fixed a spelling error
inside gdb_ari.sh that prevented it from working correctly before...

So I would like to propose this patch:


Pierre Muller as ARI maintainer.


2013-04-29  Pierre Muller  <muller@sourceware.org>

        * dwarf2read.c (handle_DW_AT_stmt_list): Avoid ARI warning for
        editCase function rule.
        (get_DW_AT_signature_type): Likewise.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.790
diff -u -p -r1.790 dwarf2read.c
--- dwarf2read.c        29 Apr 2013 05:05:44 -0000      1.790
+++ dwarf2read.c        29 Apr 2013 08:34:26 -0000
@@ -8053,7 +8053,7 @@ find_file_and_directory (struct die_info

 static void
 handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu,
-                       const char *comp_dir)
+                       const char *comp_dir) /ARI: editCase function */
 {
   struct attribute *attr;

@@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *di
    reading in and processing the type unit if necessary.  */

 static struct type *
-get_DW_AT_signature_type /* ARI: editCase */
-  (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu)
+get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,
+                         struct dwarf2_cu *cu) /* ARI: editCase function */
 {
   /* Yes, DW_AT_signature can use a non-ref_sig8 reference.  */
   if (is_ref_attr (attr))




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : lundi 29 avril 2013 07:09
> À : gdb-patches@sourceware.org
> Cc : Joel Brobecker
> Objet : [commit] Add ARI marker to get_DW_AT_signature_type.
> 
> Hello,
> 
> As discussed at:
> http://www.sourceware.org/ml/gdb-patches/2013-04/msg00564.html
> 
> gdb/ChangeLog:
> 
>         * dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.
> 
> Tested by rebuilding GDB. Checked in.
> 
> ---
>  gdb/ChangeLog    |    4 ++++
>  gdb/dwarf2read.c |    4 ++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 630fd1d..429445f 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-04-29  Joel Brobecker  <brobecker@adacore.com>
> +
> +	* dwarf2read.c (get_DW_AT_signature_type): Add ARI marker.
> +
>  2013-04-28  Yao Qi  <yao@codesourcery.com>
> 
>  	* solib-dsbt.c (fetch_loadmap): Re-indent.
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 37b7dc4..bd162e6 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *die,
ULONGEST
> signature,
>     reading in and processing the type unit if necessary.  */
> 
>  static struct type *
> -get_DW_AT_signature_type (struct die_info *die, struct attribute *attr,
> -			  struct dwarf2_cu *cu)
> +get_DW_AT_signature_type /* ARI: editCase */
> +  (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu)
>  {
>    /* Yes, DW_AT_signature can use a non-ref_sig8 reference.  */
>    if (is_ref_attr (attr))
> --
> 1.7.10.4

RE: [commit] Add ARI marker to get_DW_AT_signature_type.

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : lundi 29 avril 2013 11:01
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [commit] Add ARI marker to get_DW_AT_signature_type.
> 
> > So I would like to propose this patch:
> >
> >
> > Pierre Muller as ARI maintainer.
> >
> >
> > 2013-04-29  Pierre Muller  <muller@sourceware.org>
> >
> >         * dwarf2read.c (handle_DW_AT_stmt_list): Avoid ARI warning for
> >         editCase function rule.
> >         (get_DW_AT_signature_type): Likewise.
> 
> That looks good to me. My patch was based on a misunderstand from
> our previous discussion. Note the small typo below, however:

  Committed after fixing the typo you found and checking compilation
for mingw32 system.

Thanks for the approval,


Pierre Muller