From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12006 invoked by alias); 18 Apr 2013 22:20:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11954 invoked by uid 89); 18 Apr 2013 22:20:25 -0000 X-Spam-SWARE-Status: No, score=4.1 required=5.0 tests=AWL,BAYES_50,KHOP_DNSBL_BUMP,KHOP_THREADED,MSGID_MULTIPLE_AT,RCVD_IN_HOSTKARMA_BL,RCVD_IN_JMF_BL autolearn=no version=3.3.1 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.47) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 22:19:55 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r3IMJjKh027528 ; Fri, 19 Apr 2013 00:19:45 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms18.u-strasbg.fr [130.79.204.118]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r3IMJiBF015904 ; Fri, 19 Apr 2013 00:19:45 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r3IMJhgD023351 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 19 Apr 2013 00:19:43 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <20130418015112.GA28716@sourceware.org> <20130418151631.GI3525@adacore.com> In-Reply-To: <20130418151631.GI3525@adacore.com> Subject: RE: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt Date: Fri, 19 Apr 2013 14:29:00 -0000 Message-ID: <001b01ce3c82$d36e2870$7a4a7950$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00575.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: jeudi 18 avril 2013 17:17 > =C0=A0: GDB Administrator > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-= 18- > gmt >=20 > > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts > lower case but has uppercased letters. > > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die, > struct attribute *attr, struct dwarf2_cu *cu) >=20 > Let's add an ARI marker to accept this as a valid exception... I agree in principle, but the problem is that to avoid the warning you should add=20 /* ARI: editCase */ comment... And the natural position to insert such comment would=20 be after the closing brace of the parameter list. As you can see above, the function header of get_DW_AT_signature_type is already on two lines... But comments are handled early in gdb_ari.sh gawk script, as all comments are removed later on. But this means that it would be difficult to parse multilines for this ARI comment... To put it bluntly, once again my AWK level is too low to fix this kind of issues... Pierre Muller as not-efficient ARI maintainer