From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6875 invoked by alias); 29 Apr 2013 09:01:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6864 invoked by uid 89); 29 Apr 2013 09:01:22 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Apr 2013 09:01:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1ED222EB52; Mon, 29 Apr 2013 05:01:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pJKJtv5wI2UV; Mon, 29 Apr 2013 05:01:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A241D2E4A6; Mon, 29 Apr 2013 05:01:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DC542C3E3B; Mon, 29 Apr 2013 02:01:08 -0700 (PDT) Date: Mon, 29 Apr 2013 15:30:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [commit] Add ARI marker to get_DW_AT_signature_type. Message-ID: <20130429090108.GW3525@adacore.com> References: <20130418151631.GI3525@adacore.com> <1367212141-16536-1-git-send-email-brobecker@adacore.com> <006f01ce44b4$dc904ed0$95b0ec70$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <006f01ce44b4$dc904ed0$95b0ec70$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00863.txt.bz2 > So I would like to propose this patch: > > > Pierre Muller as ARI maintainer. > > > 2013-04-29 Pierre Muller > > * dwarf2read.c (handle_DW_AT_stmt_list): Avoid ARI warning for > editCase function rule. > (get_DW_AT_signature_type): Likewise. That looks good to me. My patch was based on a misunderstand from our previous discussion. Note the small typo below, however: > > Index: dwarf2read.c > =================================================================== > RCS file: /cvs/src/src/gdb/dwarf2read.c,v > retrieving revision 1.790 > diff -u -p -r1.790 dwarf2read.c > --- dwarf2read.c 29 Apr 2013 05:05:44 -0000 1.790 > +++ dwarf2read.c 29 Apr 2013 08:34:26 -0000 > @@ -8053,7 +8053,7 @@ find_file_and_directory (struct die_info > > static void > handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu, > - const char *comp_dir) > + const char *comp_dir) /ARI: editCase function */ ^^^^ Missing "* " after "/" > { > struct attribute *attr; > > @@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *di > reading in and processing the type unit if necessary. */ > > static struct type * > -get_DW_AT_signature_type /* ARI: editCase */ > - (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu) > +get_DW_AT_signature_type (struct die_info *die, struct attribute *attr, > + struct dwarf2_cu *cu) /* ARI: editCase function */ > { > /* Yes, DW_AT_signature can use a non-ref_sig8 reference. */ > if (is_ref_attr (attr)) > > > > > > -----Message d'origine----- > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] De la part de Joel Brobecker > > Envoyé : lundi 29 avril 2013 07:09 > > À : gdb-patches@sourceware.org > > Cc : Joel Brobecker > > Objet : [commit] Add ARI marker to get_DW_AT_signature_type. > > > > Hello, > > > > As discussed at: > > http://www.sourceware.org/ml/gdb-patches/2013-04/msg00564.html > > > > gdb/ChangeLog: > > > > * dwarf2read.c (get_DW_AT_signature_type): Add ARI marker. > > > > Tested by rebuilding GDB. Checked in. > > > > --- > > gdb/ChangeLog | 4 ++++ > > gdb/dwarf2read.c | 4 ++-- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > > index 630fd1d..429445f 100644 > > --- a/gdb/ChangeLog > > +++ b/gdb/ChangeLog > > @@ -1,3 +1,7 @@ > > +2013-04-29 Joel Brobecker > > + > > + * dwarf2read.c (get_DW_AT_signature_type): Add ARI marker. > > + > > 2013-04-28 Yao Qi > > > > * solib-dsbt.c (fetch_loadmap): Re-indent. > > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > > index 37b7dc4..bd162e6 100644 > > --- a/gdb/dwarf2read.c > > +++ b/gdb/dwarf2read.c > > @@ -17924,8 +17924,8 @@ get_signatured_type (struct die_info *die, > ULONGEST > > signature, > > reading in and processing the type unit if necessary. */ > > > > static struct type * > > -get_DW_AT_signature_type (struct die_info *die, struct attribute *attr, > > - struct dwarf2_cu *cu) > > +get_DW_AT_signature_type /* ARI: editCase */ > > + (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu) > > { > > /* Yes, DW_AT_signature can use a non-ref_sig8 reference. */ > > if (is_ref_attr (attr)) > > -- > > 1.7.10.4 > -- Joel