From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt
Date: Fri, 19 Apr 2013 14:29:00 -0000 [thread overview]
Message-ID: <001b01ce3c82$d36e2870$7a4a7950$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20130418151631.GI3525@adacore.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : jeudi 18 avril 2013 17:17
> À : GDB Administrator
> Cc : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-
> gmt
>
> > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts
> lower case but has uppercased letters.
> > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die,
> struct attribute *attr, struct dwarf2_cu *cu)
>
> Let's add an ARI marker to accept this as a valid exception...
I agree in principle,
but the problem is that to avoid the warning you should add
/* ARI: editCase */ comment...
And the natural position to insert such comment would
be after the closing brace of the parameter list.
As you can see above, the function header of get_DW_AT_signature_type is
already
on two lines...
But comments are handled early in gdb_ari.sh gawk script,
as all comments are removed later on.
But this means that it would be difficult to parse multilines
for this ARI comment...
To put it bluntly,
once again my AWK level is too low to fix this kind of issues...
Pierre Muller
as not-efficient ARI maintainer
next prev parent reply other threads:[~2013-04-18 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 16:02 GDB Administrator
2013-04-19 14:27 ` Joel Brobecker
2013-04-19 14:29 ` Pierre Muller [this message]
2013-04-19 14:31 ` Joel Brobecker
2013-04-29 14:47 ` [commit] Add ARI marker to get_DW_AT_signature_type Joel Brobecker
2013-04-29 15:30 ` Pierre Muller
2013-04-29 15:30 ` Joel Brobecker
2013-04-29 17:19 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01ce3c82$d36e2870$7a4a7950$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox