Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt

[Joel Brobecker <brobecker@adacore.com>]

On Fri, Apr 19, 2013 at 12:19:41AM +0200, Pierre Muller wrote:
> 
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Joel Brobecker
> > Envoyé : jeudi 18 avril 2013 17:17
> > À : GDB Administrator
> > Cc : gdb-patches@sourceware.org
> > Objet : Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-
> > gmt
> > 
> > > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts
> > lower case but has uppercased letters.
> > > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die,
> > struct attribute *attr,			  struct dwarf2_cu *cu)
> > 
> > Let's add an ARI marker to accept this as a valid exception...
> I agree in principle,
> but the problem is that to avoid the warning you should add 
> /* ARI: editCase */ comment...
> And the natural position to insert such comment would 
> be after the closing brace of the parameter list.

I was actually thinking of writing it like so:

    get_DW_AT_signature_type /* ARI: editCase */
      (struct die_info *die, struct attribute *attr,
       struct dwarf2_cu *cu)
    {
    }

Not ideal, but I do not think it would be the first time that
the arguments start on the line following the function name...

-- 
Joel