From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13889 invoked by alias); 19 Apr 2013 07:01:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13872 invoked by uid 89); 19 Apr 2013 07:01:33 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 07:01:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 338132EB4F; Fri, 19 Apr 2013 03:01:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kM0RmeXRA8WQ; Fri, 19 Apr 2013 03:01:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 015112E28F; Fri, 19 Apr 2013 03:01:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 568CEC3A3A; Fri, 19 Apr 2013 00:01:29 -0700 (PDT) Date: Fri, 19 Apr 2013 14:31:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18-gmt Message-ID: <20130419070129.GJ3525@adacore.com> References: <20130418015112.GA28716@sourceware.org> <20130418151631.GI3525@adacore.com> <001b01ce3c82$d36e2870$7a4a7950$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <001b01ce3c82$d36e2870$7a4a7950$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00577.txt.bz2 On Fri, Apr 19, 2013 at 12:19:41AM +0200, Pierre Muller wrote: > > > > -----Message d'origine----- > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] De la part de Joel Brobecker > > Envoyé : jeudi 18 avril 2013 17:17 > > À : GDB Administrator > > Cc : gdb-patches@sourceware.org > > Objet : Re: New ARI warning Thu Apr 18 01:51:12 UTC 2013 in -D 2013-04-18- > > gmt > > > > > > gdb/dwarf2read.c:17927: code: editCase function: Function name starts > > lower case but has uppercased letters. > > > gdb/dwarf2read.c:17927:get_DW_AT_signature_type (struct die_info *die, > > struct attribute *attr, struct dwarf2_cu *cu) > > > > Let's add an ARI marker to accept this as a valid exception... > I agree in principle, > but the problem is that to avoid the warning you should add > /* ARI: editCase */ comment... > And the natural position to insert such comment would > be after the closing brace of the parameter list. I was actually thinking of writing it like so: get_DW_AT_signature_type /* ARI: editCase */ (struct die_info *die, struct attribute *attr, struct dwarf2_cu *cu) { } Not ideal, but I do not think it would be the first time that the arguments start on the line following the function name... -- Joel