From: pbonzini@redhat.com (Paolo Bonzini)
Subject: [ltt-dev] [PATCH v2] cmm: provide lightweight smp_rmb/smp_wmb on PPC
Date: Thu, 22 Sep 2011 10:42:52 +0200 [thread overview]
Message-ID: <1316680972-15081-1-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <20110921234242.GG2394@linux.vnet.ibm.com>
lwsync orders loads in cacheable memory with respect to other loads,
and stores in cacheable memory with respect to other stores. Use it
to implement smp_rmb/smp_wmb.
The heavy-weight sync is still used for the "full" rmb/wmb operations,
as well as for smp_mb.
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
---
urcu/arch/ppc.h | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/urcu/arch/ppc.h b/urcu/arch/ppc.h
index a03d688..05f7db6 100644
--- a/urcu/arch/ppc.h
+++ b/urcu/arch/ppc.h
@@ -32,7 +32,15 @@ extern "C" {
/* Include size of POWER5+ L3 cache lines: 256 bytes */
#define CAA_CACHE_LINE_SIZE 256
-#define cmm_mb() asm volatile("sync":::"memory")
+#define cmm_mb() asm volatile("sync":::"memory")
+
+/* lwsync does not preserve ordering of cacheable vs. non-cacheable
+ * accesses, but it is good when MMIO is not in use. An eieio+lwsync
+ * pair is also not enough for rmb, because it will order cacheable
+ * and non-cacheable memory operations separately---i.e. not the latter
+ * against the former. */
+#define cmm_smp_rmb() asm volatile("lwsync":::"memory")
+#define cmm_smp_wmb() asm volatile("lwsync":::"memory")
#define mftbl() \
({ \
--
1.7.6
next prev parent reply other threads:[~2011-09-22 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 7:12 [ltt-dev] [URCU PATCH] cmm: provide lightweight rmb/wmb " Paolo Bonzini
2011-09-20 16:31 ` Mathieu Desnoyers
2011-09-20 16:39 ` Paolo Bonzini
2011-09-20 16:51 ` Mathieu Desnoyers
2011-09-21 7:20 ` Paolo Bonzini
2011-09-21 23:43 ` Paul E. McKenney
2011-09-21 23:42 ` Paul E. McKenney
2011-09-22 8:42 ` Paolo Bonzini [this message]
2011-09-22 9:10 ` [ltt-dev] [PATCH v2] cmm: provide lightweight smp_rmb/smp_wmb " Mathieu Desnoyers
2011-09-22 14:49 ` Paul E. McKenney
2011-09-22 14:57 ` Mathieu Desnoyers
2011-09-22 15:26 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316680972-15081-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox