Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Luis Machado <luis.machado@arm.com>,  Tom Tromey <tom@tromey.com>,
	"Aktemur, Tankut Baris via Gdb" <gdb@sourceware.org>,
	 "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Subject: Re: automated coding style tool
Date: Tue, 14 Jan 2025 16:04:56 -0700	[thread overview]
Message-ID: <87msftuhd3.fsf@tromey.com> (raw)
In-Reply-To: <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> (Simon Marchi's message of "Tue, 14 Jan 2025 12:23:43 -0500")

Simon> If we don't like what the tool outputs, we can argue over than
Simon> and change the tool.

Yeah - but that's where we're already at.  Like, I ran clang-format on
gdb and read the diffs and found a bunch of things I didn't like.  IIRC
the main offenders were bin-packing.  I imagine Pedro did this too,
since he's made similar comments in the past.

I at least CCd myself on upstream bugs against the tool.  I commented
on some, maybe filed some too (don't remember).

I'm not super interested in hacking on clang-format, but the tool is
there and all the information for someone who is.

Simon> Also, if are missing some features to get the output we want, nobody is
Simon> going to magically implement them for us.  And if we don't use the tool,
Simon> there's no motivation for us either to go implement the changes.  I
Simon> think that the only way to get the ball rolling is to start using the
Simon> tool, even if the output is not ideal, and then if there's something
Simon> really annoying, one of us *might* have the motivation to go improve the
Simon> tool.

I'm in favor of using a tool but my view is that it has to meet some
minimal standard of usefulness.  I just think clang-format does not do
this.

Tom

  reply	other threads:[~2025-01-14 23:05 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 21:52 Contributing to gdb shaunak saha via Gdb
2024-06-17 12:21 ` Guinevere Larsen via Gdb
2024-06-17 15:00   ` DCO: Was: " Andrew Pinski via Gdb
2024-06-17 15:57     ` Guinevere Larsen via Gdb
2024-06-17 16:07       ` Jan Beulich via Gdb
2024-06-17 16:32       ` Eli Zaretskii via Gdb
2024-06-17 16:37         ` Guinevere Larsen via Gdb
2024-06-17 16:45           ` Eli Zaretskii via Gdb
2024-06-17 18:18             ` Guinevere Larsen via Gdb
2024-06-17 18:24               ` Andrew Pinski via Gdb
2024-06-17 19:57                 ` Eli Zaretskii via Gdb
2024-06-17 19:37               ` Eli Zaretskii via Gdb
2024-06-17 19:48                 ` Guinevere Larsen via Gdb
2024-06-18 12:25                   ` Eli Zaretskii via Gdb
2024-06-27 17:48                     ` Thiago Jung Bauermann via Gdb
2024-06-27 19:03                       ` Eli Zaretskii via Gdb
2024-06-29  3:27                         ` Thiago Jung Bauermann via Gdb
2024-06-17 19:15           ` Arsen Arsenović via Gdb
2024-06-18 11:54             ` Eli Zaretskii via Gdb
2024-06-28  0:43               ` NightStrike via Gdb
2024-06-28  6:08                 ` Eli Zaretskii via Gdb
2024-06-21 13:20       ` Nick Clifton via Gdb
2024-06-23 22:06       ` Tom Tromey
2024-12-02  8:56         ` Luis Machado via Gdb
2025-01-13 17:14           ` Andrew Burgess via Gdb
2025-01-13 17:32             ` Eli Zaretskii via Gdb
2025-01-17 10:37               ` Florian Weimer via Gdb
2025-01-17 10:44                 ` Luis Machado via Gdb
2025-01-17 13:01                 ` Eli Zaretskii via Gdb
2025-01-21 19:10                   ` Guinevere Larsen via Gdb
2025-01-13 17:42             ` Simon Marchi via Gdb
2025-01-14 15:17               ` automated coding style tool (was: RE: DCO: Was: Re: Contributing to gdb) Aktemur, Tankut Baris via Gdb
2025-01-14 17:11                 ` automated coding style tool Tom Tromey
2025-01-14 17:14                   ` Luis Machado via Gdb
2025-01-14 17:23                     ` Simon Marchi via Gdb
2025-01-14 23:04                       ` Tom Tromey [this message]
2025-01-15  6:03                         ` Maciej W. Rozycki
2025-01-18 18:39                           ` Tom Tromey
2025-01-22 22:36                             ` Maciej W. Rozycki
2025-01-15 10:20                         ` Luis Machado via Gdb
2025-01-15 12:24                           ` Aktemur, Tankut Baris via Gdb
2025-01-17 13:42                           ` Andrew Burgess via Gdb
2025-01-17 15:13                             ` Joel Brobecker via Gdb
2025-01-17 15:55                               ` Simon Marchi via Gdb
2025-01-17 17:36                                 ` Phi via Gdb
2025-01-17 19:27                                   ` Simon Marchi via Gdb
2025-01-18 18:56                           ` Tom Tromey
2025-01-20 11:30                             ` Luis Machado via Gdb
2025-01-14 17:15                   ` Simon Marchi via Gdb
2025-01-14  9:49             ` DCO: Was: Re: Contributing to gdb Luis Machado via Gdb
2025-01-14 13:56               ` Eli Zaretskii via Gdb
2025-01-14 15:10               ` Simon Marchi via Gdb
2025-01-14 15:28                 ` Luis Machado via Gdb
2025-01-14 15:47                   ` Simon Marchi via Gdb
2025-01-14 16:33                     ` Luis Machado via Gdb
2025-01-14 16:42                     ` Eli Zaretskii via Gdb
2025-01-15 11:49                       ` Mark Wielaard
2025-01-14 16:46               ` Andrew Burgess via Gdb
2025-01-15 11:25                 ` Mark Wielaard
2025-01-15  6:20               ` Maciej W. Rozycki
2025-01-15 11:05               ` Mark Wielaard
2025-01-14 15:28             ` Mark Wielaard
2025-01-17 10:42               ` Florian Weimer via Gdb
2025-01-17 13:09                 ` Eli Zaretskii via Gdb
2025-01-19 16:37                 ` Mark Wielaard
2025-01-27 15:55                 ` DCO Bradley M. Kuhn via Gdb
2025-01-27 16:36                   ` DCO Krzysztof Siewicz via Gdb
2025-01-27 17:22                   ` DCO Guinevere Larsen via Gdb
2025-01-31 19:36                     ` DCO Mark Wielaard
2024-06-18 13:32     ` DCO: Was: Re: Contributing to gdb Michael Matz via Gdb
2024-06-19  7:38   ` shaunak saha via Gdb
2024-06-19 12:07     ` Guinevere Larsen via Gdb
2024-06-25 22:27       ` shaunak saha via Gdb
2024-06-26 17:38 ` Tom Tromey
2024-06-28  7:23   ` shaunak saha via Gdb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msftuhd3.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb@sourceware.org \
    --cc=luis.machado@arm.com \
    --cc=simark@simark.ca \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox