From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mFQ9A8nthmdUSg8AWB0awg (envelope-from ) for ; Tue, 14 Jan 2025 18:05:45 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XPufchJp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 08B4C1E100; Tue, 14 Jan 2025 18:05:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 839451E05C for ; Tue, 14 Jan 2025 18:05:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43664385C40A for ; Tue, 14 Jan 2025 23:05:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43664385C40A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XPufchJp Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id CA449385C407 for ; Tue, 14 Jan 2025 23:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA449385C407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA449385C407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736895900; cv=none; b=m4dH0W/XtPlBh0OZ3lXQLMeUOUvfOu7f+BMqMzrujLoMNASWME9ge8e7IVsQqIv6tKyuSGZE6mVAiSMF0icMH3Ckak7a7pJAP48h2CTGA7InP1NN/65M/2Y3UcXLUah3Qg8mNl9mRSj8Oqa/+246fTxYA+R0gHjzGWd8O7rb0io= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736895900; c=relaxed/simple; bh=JLJW2GXaV08ZwItgrt6TYimCnxYrKbVVUTKs8t1IeLk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hwCN5RiJefhdUiG6o6obVI53G51sEaWLQFtOV8x+O7ttOsneQkA8bWYUa0yg8JXJ0yg4wHf8S8PG4Vg2h/7b6hXLLImOA3Gq8zS6AjNRF3ARPRgzTdYtsZPytHYOnhFFe9R7PcRoQgNYCQV5nXEukeWhpV7pfvEZJsVTpwZme8Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA449385C407 Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id Xj6FtOEojdz4NXpy0tsshi; Tue, 14 Jan 2025 23:05:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Xpxztsx36jXFNXpxztgNCE; Tue, 14 Jan 2025 23:04:59 +0000 X-Authority-Analysis: v=2.4 cv=HaASTDE8 c=1 sm=1 tr=0 ts=6786ed9b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=chM7SVRsCVbp_DRFChcA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/KCCQqK8zJm+DK1hsUdnJtZMKKu/fGN9jBGJawKUSnw=; b=XPufchJpCxkTHN15IRJlmxjH0j 857f0CD7gt0gdRO9ru4pOaEnUhSm18J9j7S23Q1LZj20L3t0cx/J7MpznHRCJ9AXbYbxAeWEeRGYo CbV4oNis5BZn3c8BvnlLJuuDb; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:46976 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tXpxy-000uNy-0i; Tue, 14 Jan 2025 16:04:58 -0700 From: Tom Tromey To: Simon Marchi Cc: Luis Machado , Tom Tromey , "Aktemur, Tankut Baris via Gdb" , "Aktemur, Tankut Baris" Subject: Re: automated coding style tool In-Reply-To: <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> (Simon Marchi's message of "Tue, 14 Jan 2025 12:23:43 -0500") References: <86538dac-6c3a-4b9e-9de9-3906e645fa4d@redhat.com> <87y16vwbzl.fsf@tromey.com> <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> X-Attribution: Tom Date: Tue, 14 Jan 2025 16:04:56 -0700 Message-ID: <87msftuhd3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1tXpxy-000uNy-0i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (prentzel) [97.118.36.154]:46976 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCqM67Brpm7VGSoupBKX/2P5XggCyvx5UfY4tcr/fCEo5IzVTpGqqX4/BhO3GNuPLDPfVs/45EAx/VrrWmPKyIqdcRfK8jNH7P8S2auqcQyNqAxb53kM 3sJJb6+KRT2yPID/rzbnG/gvCLf1FehPnbkEsZSj+u81SWKziosWB6xtm/1/ZSjlbu1f3FfFNTUsZw== X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" Simon> If we don't like what the tool outputs, we can argue over than Simon> and change the tool. Yeah - but that's where we're already at. Like, I ran clang-format on gdb and read the diffs and found a bunch of things I didn't like. IIRC the main offenders were bin-packing. I imagine Pedro did this too, since he's made similar comments in the past. I at least CCd myself on upstream bugs against the tool. I commented on some, maybe filed some too (don't remember). I'm not super interested in hacking on clang-format, but the tool is there and all the information for someone who is. Simon> Also, if are missing some features to get the output we want, nobody is Simon> going to magically implement them for us. And if we don't use the tool, Simon> there's no motivation for us either to go implement the changes. I Simon> think that the only way to get the ball rolling is to start using the Simon> tool, even if the output is not ideal, and then if there's something Simon> really annoying, one of us *might* have the motivation to go improve the Simon> tool. I'm in favor of using a tool but my view is that it has to meet some minimal standard of usefulness. I just think clang-format does not do this. Tom