From: Luis Machado via Gdb <gdb@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
"Aktemur, Tankut Baris via Gdb" <gdb@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>,
"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Subject: Re: automated coding style tool
Date: Tue, 14 Jan 2025 17:14:57 +0000 [thread overview]
Message-ID: <ae76fbb3-b619-48e6-a558-a49ea67f88fe@arm.com> (raw)
In-Reply-To: <87tta1qq1i.fsf@tromey.com>
On 1/14/25 17:11, Tom Tromey wrote:
>>>>>> Aktemur, Tankut Baris via Gdb <gdb@sourceware.org> writes:
>
>> Regarding the automated coding style tool: is there any active attempt
>> to pursue this goal?
>
> Every year or two I take another look at clang-format.
> The discussion is here:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=30098
>
>> Tom mentioned his t/clang-format branch in that email thread. I checked
>> the branch. The clang-format config file has
>> # BasedOnStyle: GNU
>> Is the GDB coding style so off from the built-in GNU style
>> that it cannot be reused?
>
> I don't recall why I commented this out. Anyway clang-format doesn't
> come very close to GNU style. I'd be ok with ignoring most of the
> little differences (i.e., I don't care about goto label placement), but
> the bin packing output is just super ugly some of the time.
>
> Tom
I'd go for a tool, even if it is slightly to moderately different from what
we tend to use. It's not like the GNU style has been updated to cope with
the more recent C++ syntax, so we have some stuff that isn't properly
documented.
The tool would simplify that.
Also, the style of comment we use (/* */) doesn't go well with clang-format
from what I recall. But we can just drop options that deal with comments.
next prev parent reply other threads:[~2025-01-14 17:16 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 21:52 Contributing to gdb shaunak saha via Gdb
2024-06-17 12:21 ` Guinevere Larsen via Gdb
2024-06-17 15:00 ` DCO: Was: " Andrew Pinski via Gdb
2024-06-17 15:57 ` Guinevere Larsen via Gdb
2024-06-17 16:07 ` Jan Beulich via Gdb
2024-06-17 16:32 ` Eli Zaretskii via Gdb
2024-06-17 16:37 ` Guinevere Larsen via Gdb
2024-06-17 16:45 ` Eli Zaretskii via Gdb
2024-06-17 18:18 ` Guinevere Larsen via Gdb
2024-06-17 18:24 ` Andrew Pinski via Gdb
2024-06-17 19:57 ` Eli Zaretskii via Gdb
2024-06-17 19:37 ` Eli Zaretskii via Gdb
2024-06-17 19:48 ` Guinevere Larsen via Gdb
2024-06-18 12:25 ` Eli Zaretskii via Gdb
2024-06-27 17:48 ` Thiago Jung Bauermann via Gdb
2024-06-27 19:03 ` Eli Zaretskii via Gdb
2024-06-29 3:27 ` Thiago Jung Bauermann via Gdb
2024-06-17 19:15 ` Arsen Arsenović via Gdb
2024-06-18 11:54 ` Eli Zaretskii via Gdb
2024-06-28 0:43 ` NightStrike via Gdb
2024-06-28 6:08 ` Eli Zaretskii via Gdb
2024-06-21 13:20 ` Nick Clifton via Gdb
2024-06-23 22:06 ` Tom Tromey
2024-12-02 8:56 ` Luis Machado via Gdb
2025-01-13 17:14 ` Andrew Burgess via Gdb
2025-01-13 17:32 ` Eli Zaretskii via Gdb
2025-01-17 10:37 ` Florian Weimer via Gdb
2025-01-17 10:44 ` Luis Machado via Gdb
2025-01-17 13:01 ` Eli Zaretskii via Gdb
2025-01-21 19:10 ` Guinevere Larsen via Gdb
2025-01-13 17:42 ` Simon Marchi via Gdb
2025-01-14 15:17 ` automated coding style tool (was: RE: DCO: Was: Re: Contributing to gdb) Aktemur, Tankut Baris via Gdb
2025-01-14 17:11 ` automated coding style tool Tom Tromey
2025-01-14 17:14 ` Luis Machado via Gdb [this message]
2025-01-14 17:23 ` Simon Marchi via Gdb
2025-01-14 23:04 ` Tom Tromey
2025-01-15 6:03 ` Maciej W. Rozycki
2025-01-18 18:39 ` Tom Tromey
2025-01-22 22:36 ` Maciej W. Rozycki
2025-01-15 10:20 ` Luis Machado via Gdb
2025-01-15 12:24 ` Aktemur, Tankut Baris via Gdb
2025-01-17 13:42 ` Andrew Burgess via Gdb
2025-01-17 15:13 ` Joel Brobecker via Gdb
2025-01-17 15:55 ` Simon Marchi via Gdb
2025-01-17 17:36 ` Phi via Gdb
2025-01-17 19:27 ` Simon Marchi via Gdb
2025-01-18 18:56 ` Tom Tromey
2025-01-20 11:30 ` Luis Machado via Gdb
2025-01-14 17:15 ` Simon Marchi via Gdb
2025-01-14 9:49 ` DCO: Was: Re: Contributing to gdb Luis Machado via Gdb
2025-01-14 13:56 ` Eli Zaretskii via Gdb
2025-01-14 15:10 ` Simon Marchi via Gdb
2025-01-14 15:28 ` Luis Machado via Gdb
2025-01-14 15:47 ` Simon Marchi via Gdb
2025-01-14 16:33 ` Luis Machado via Gdb
2025-01-14 16:42 ` Eli Zaretskii via Gdb
2025-01-15 11:49 ` Mark Wielaard
2025-01-14 16:46 ` Andrew Burgess via Gdb
2025-01-15 11:25 ` Mark Wielaard
2025-01-15 6:20 ` Maciej W. Rozycki
2025-01-15 11:05 ` Mark Wielaard
2025-01-14 15:28 ` Mark Wielaard
2025-01-17 10:42 ` Florian Weimer via Gdb
2025-01-17 13:09 ` Eli Zaretskii via Gdb
2025-01-19 16:37 ` Mark Wielaard
2025-01-27 15:55 ` DCO Bradley M. Kuhn via Gdb
2025-01-27 16:36 ` DCO Krzysztof Siewicz via Gdb
2025-01-27 17:22 ` DCO Guinevere Larsen via Gdb
2025-01-31 19:36 ` DCO Mark Wielaard
2024-06-18 13:32 ` DCO: Was: Re: Contributing to gdb Michael Matz via Gdb
2024-06-19 7:38 ` shaunak saha via Gdb
2024-06-19 12:07 ` Guinevere Larsen via Gdb
2024-06-25 22:27 ` shaunak saha via Gdb
2024-06-26 17:38 ` Tom Tromey
2024-06-28 7:23 ` shaunak saha via Gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae76fbb3-b619-48e6-a558-a49ea67f88fe@arm.com \
--to=gdb@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simark@simark.ca \
--cc=tankut.baris.aktemur@intel.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox