Re: [PATCH] sim: profile: implement --profile-file backend

[Doug Evans <dje@google.com>]

On Wed, Apr 21, 2010 at 5:39 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> sorry, i noticed i need these two fixes for some ports.  the ones i was build
> testing worked, but i wrote a small helper script to build all of them and
> noticed the problem.  wish sim had a --enable-targets=all option like gdb, but
> in the mean time, i'll stick with this script for future patches.
> -mike
>
> sim/frv/:
> 2010-04-21  Mike Frysinger  <vapier@gentoo.org>
>
>        * profile.c (sim_profile_print_bar): Add cpu argument.
>
> RCS file: /cvs/src/src/sim/frv/profile.c,v
> retrieving revision 1.11
> diff -u -p -r1.11 profile.c
> --- sim/frv/profile.c   1 Jan 2010 10:03:29 -0000       1.11
> +++ sim/frv/profile.c   22 Apr 2010 00:34:57 -0000
> @@ -2042,7 +2042,7 @@ print_parallel (SIM_CPU *cpu, int verbos
>                                 max_name_len, slot_names[i],
>                                 max_val < 10000 ? 5 : 10,
>                                 COMMAS (INSNS_IN_SLOT (i)));
> -                 sim_profile_print_bar (sd, PROFILE_HISTOGRAM_WIDTH,
> +                 sim_profile_print_bar (sd, cpu, PROFILE_HISTOGRAM_WIDTH,
>                                         INSNS_IN_SLOT (i),
>                                         max_val);
>                  sim_io_printf (sd, "\n");
>
> sim/common/:
> 2010-04-21  Mike Frysinger  <vapier@gentoo.org>
>
>        * sim-profile.h (sim_profile_print_bar): Use sim_cpu, not SIM_CPU.
>
> RCS file: /cvs/src/src/sim/common/sim-profile.h,v
> retrieving revision 1.10
> diff -u -p -r1.10 sim-profile.h
> --- sim/common/sim-profile.h    22 Apr 2010 00:26:08 -0000      1.10
> +++ sim/common/sim-profile.h    22 Apr 2010 00:36:05 -0000
> @@ -308,6 +308,6 @@ do { \
>
>  /* Misc. utilities.  */
>
> -extern void sim_profile_print_bar (SIM_DESC, SIM_CPU *, unsigned int, unsigned int, unsigned int);
> +extern void sim_profile_print_bar (SIM_DESC, sim_cpu *, unsigned int, unsigned int, unsigned int);
>
>  #endif /* SIM_PROFILE_H */
>

Sure, no problem.