Re: [PATCH] sim: profile: implement --profile-file backend

[Hans-Peter Nilsson <hp@bitrange.com>]

On Wed, 21 Apr 2010, Mike Frysinger wrote:
> sorry, i noticed i need these two fixes for some ports.  the ones i was build
> testing worked, but i wrote a small helper script to build all of them and
> noticed the problem.  wish sim had a --enable-targets=all option like gdb, but
> in the mean time, i'll stick with this script for future patches.
> -mike
>
> sim/frv/:
> 2010-04-21  Mike Frysinger  <vapier@gentoo.org>
>
> 	* profile.c (sim_profile_print_bar): Add cpu argument.

Please be much more careful when you test your patches.
(I think you forgot to run your script. ;)

Building all simulators seems reasonable to me, even so to test
those with test-suites (though it requires building binutils,
which thankfully can be checked out in the same source-tree).

Your change broke at least cris-elf, iq2000-elf and m32r-elf,
as you didn't adjust calls in sim/common/cgen-scache.c.

brgds, H-P