Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: "Hans-Peter Nilsson" <hp@bitrange.com>
Cc: Doug Evans <dje@google.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: profile: implement --profile-file backend
Date: Thu, 22 Apr 2010 02:17:00 -0000	[thread overview]
Message-ID: <201004212218.12823.vapier@gentoo.org> (raw)
In-Reply-To: <alpine.BSF.2.00.1004212143050.79451@dair.pair.com>

[-- Attachment #1: Type: Text/Plain, Size: 1245 bytes --]

On Wednesday 21 April 2010 21:49:34 Hans-Peter Nilsson wrote:
> Your change broke at least cris-elf, iq2000-elf and m32r-elf,
> as you didn't adjust calls in sim/common/cgen-scache.c.

i'm build+check testing these sim targets:
	arm avr cr16 frv h8300 m32c mips mn10300 moxie ppc rx sh v850
those all work, but i guess none use cgen-scache

i didnt test cris iq2000 m32r because they werent even building for me in the 
past (independent of my changes).  they seem to now though, so ive added them 
to the above list.

ive added this fix to cvs.
-mike

2010-04-21  Mike Frysinger  <vapier@gentoo.org>

	* profile.c (sim_profile_print_bar): Add cpu argument.

RCS file: /cvs/src/src/sim/common/cgen-scache.c,v
retrieving revision 1.7
diff -u -p -r1.7 cgen-scache.c
--- sim/common/cgen-scache.c	1 Jan 2010 10:03:27 -0000	1.7
+++ sim/common/cgen-scache.c	22 Apr 2010 02:17:08 -0000
@@ -466,7 +466,7 @@ scache_print_profile (SIM_CPU *cpu, int 
 			 i,
 			 max_val < 10000 ? 5 : 10,
 			 sim_add_commas (buf, sizeof (buf), lengths[i]));
-	  sim_profile_print_bar (sd, PROFILE_HISTOGRAM_WIDTH,
+	  sim_profile_print_bar (sd, cpu, PROFILE_HISTOGRAM_WIDTH,
 				 lengths[i], max_val);
 	  sim_io_printf (sd, "\n");
 	}

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-04-22  2:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 20:49 Mike Frysinger
2010-04-21 22:36 ` Doug Evans
2010-04-22  0:26   ` Mike Frysinger
2010-04-22  0:39     ` Mike Frysinger
2010-04-22  1:36       ` Doug Evans
2010-04-22  1:49       ` Hans-Peter Nilsson
2010-04-22  2:17         ` Mike Frysinger [this message]
2010-04-22  2:45           ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004212218.12823.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hp@bitrange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox