From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14192 invoked by alias); 22 Apr 2010 02:17:49 -0000 Received: (qmail 14150 invoked by uid 22791); 22 Apr 2010 02:17:47 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 02:17:43 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 190FF1B4007; Thu, 22 Apr 2010 02:17:41 +0000 (UTC) From: Mike Frysinger To: "Hans-Peter Nilsson" Subject: Re: [PATCH] sim: profile: implement --profile-file backend Date: Thu, 22 Apr 2010 02:17:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.2; KDE/4.4.1; x86_64; ; ) Cc: Doug Evans , gdb-patches@sourceware.org References: <1271882917-28580-1-git-send-email-vapier@gentoo.org> <201004212039.35705.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart43863823.5lRXOvs37p"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201004212218.12823.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00731.txt.bz2 --nextPart43863823.5lRXOvs37p Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1222 On Wednesday 21 April 2010 21:49:34 Hans-Peter Nilsson wrote: > Your change broke at least cris-elf, iq2000-elf and m32r-elf, > as you didn't adjust calls in sim/common/cgen-scache.c. i'm build+check testing these sim targets: arm avr cr16 frv h8300 m32c mips mn10300 moxie ppc rx sh v850 those all work, but i guess none use cgen-scache i didnt test cris iq2000 m32r because they werent even building for me in t= he=20 past (independent of my changes). they seem to now though, so ive added th= em=20 to the above list. ive added this fix to cvs. -mike 2010-04-21 Mike Frysinger * profile.c (sim_profile_print_bar): Add cpu argument. RCS file: /cvs/src/src/sim/common/cgen-scache.c,v retrieving revision 1.7 diff -u -p -r1.7 cgen-scache.c --- sim/common/cgen-scache.c 1 Jan 2010 10:03:27 -0000 1.7 +++ sim/common/cgen-scache.c 22 Apr 2010 02:17:08 -0000 @@ -466,7 +466,7 @@ scache_print_profile (SIM_CPU *cpu, int=20 i, max_val < 10000 ? 5 : 10, sim_add_commas (buf, sizeof (buf), lengths[i])); - sim_profile_print_bar (sd, PROFILE_HISTOGRAM_WIDTH, + sim_profile_print_bar (sd, cpu, PROFILE_HISTOGRAM_WIDTH, lengths[i], max_val); sim_io_printf (sd, "\n"); } --nextPart43863823.5lRXOvs37p Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLz7HkAAoJEEFjO5/oN/WBGQIP/j4ipoY279rIcSWK4N1xhoLn sTqmxcbGaSBkLTWgNffnUZS+qL7lLyaC+tfqZJyrmT3IOrzUDaVGkmuNpXIYGF+F DSeD55W55f6zAAY/DW376YhZS1Cg5Bw3SmbRppk0uoSl7LejnNY38f6dGaEIin8a 8xZLttGfEA9+Tz0evJjU7Iuhyb7ayjTxonv6yIsQdX8DkfsO3l+pSmxW0ozxBLmW jDOzsrCaJJ7MOacHUXe2fXQY5qCUA4Rb/EF9FkUTRqa6FDWBbo2jLDv7iuxBg9Q/ lo0LzGVBCdd87J3ayXxSrhNs+BoS5g71DDmBIlJAJWFhNv8JzNq8i3Q96XpnuQdW +VIpkpEk8xhlHs+fLIXeaIIVEAN2/EEsEwEVcCg5S5Sv5Ro8ymT5oEA1k1XOCx3N E/cIKf6LeM3NALkjBCfE1cXUxQq/F+7q/7+WLkMix81GVe+vRi33FcHCzmFgJnHR TI5m8WTAoLhSZGYeTvWb9/SSdKGWjDmE1q6w8nJevxDG3bpKM3k1OzAcDEGWgDvK 55rrFJgfC+5Uwp4QEcBVN4WTzJsaFBOfXs1tqdSBnkYbYni7cWhAXyON0nnCleRV 83V4fFk7CKLQD8aqh0Os5kyuivQaRVAUBMYXBQ+l33qprDcB3xfqk4ROb7lE2FO1 oBlQOh1LFEWejDrED8PM =eumZ -----END PGP SIGNATURE----- --nextPart43863823.5lRXOvs37p--