Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: profile: implement --profile-file backend
Date: Thu, 22 Apr 2010 00:39:00 -0000	[thread overview]
Message-ID: <201004212039.35705.vapier@gentoo.org> (raw)
In-Reply-To: <201004212027.01906.vapier@gentoo.org>

[-- Attachment #1: Type: Text/Plain, Size: 1663 bytes --]

sorry, i noticed i need these two fixes for some ports.  the ones i was build
testing worked, but i wrote a small helper script to build all of them and
noticed the problem.  wish sim had a --enable-targets=all option like gdb, but
in the mean time, i'll stick with this script for future patches.
-mike

sim/frv/:
2010-04-21  Mike Frysinger  <vapier@gentoo.org>

	* profile.c (sim_profile_print_bar): Add cpu argument.

RCS file: /cvs/src/src/sim/frv/profile.c,v
retrieving revision 1.11
diff -u -p -r1.11 profile.c
--- sim/frv/profile.c	1 Jan 2010 10:03:29 -0000	1.11
+++ sim/frv/profile.c	22 Apr 2010 00:34:57 -0000
@@ -2042,7 +2042,7 @@ print_parallel (SIM_CPU *cpu, int verbos
 				 max_name_len, slot_names[i],
 				 max_val < 10000 ? 5 : 10,
 				 COMMAS (INSNS_IN_SLOT (i)));
-		  sim_profile_print_bar (sd, PROFILE_HISTOGRAM_WIDTH,
+		  sim_profile_print_bar (sd, cpu, PROFILE_HISTOGRAM_WIDTH,
 					 INSNS_IN_SLOT (i),
 					 max_val);
 		  sim_io_printf (sd, "\n");

sim/common/:
2010-04-21  Mike Frysinger  <vapier@gentoo.org>

	* sim-profile.h (sim_profile_print_bar): Use sim_cpu, not SIM_CPU.

RCS file: /cvs/src/src/sim/common/sim-profile.h,v
retrieving revision 1.10
diff -u -p -r1.10 sim-profile.h
--- sim/common/sim-profile.h	22 Apr 2010 00:26:08 -0000	1.10
+++ sim/common/sim-profile.h	22 Apr 2010 00:36:05 -0000
@@ -308,6 +308,6 @@ do { \
 
 /* Misc. utilities.  */
 
-extern void sim_profile_print_bar (SIM_DESC, SIM_CPU *, unsigned int, unsigned int, unsigned int);
+extern void sim_profile_print_bar (SIM_DESC, sim_cpu *, unsigned int, unsigned int, unsigned int);
 
 #endif /* SIM_PROFILE_H */

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-04-22  0:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 20:49 Mike Frysinger
2010-04-21 22:36 ` Doug Evans
2010-04-22  0:26   ` Mike Frysinger
2010-04-22  0:39     ` Mike Frysinger [this message]
2010-04-22  1:36       ` Doug Evans
2010-04-22  1:49       ` Hans-Peter Nilsson
2010-04-22  2:17         ` Mike Frysinger
2010-04-22  2:45           ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004212039.35705.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox