From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: profile: implement --profile-file backend
Date: Wed, 21 Apr 2010 22:36:00 -0000 [thread overview]
Message-ID: <m2we394668d1004211536qa59e2d2amda0db99f2bac4413@mail.gmail.com> (raw)
In-Reply-To: <1271882917-28580-1-git-send-email-vapier@gentoo.org>
On Wed, Apr 21, 2010 at 1:48 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> The profile code already has options and handling for accepting a file to
> write the profile output like the trace code, but it doesn't actually use
> it. At the moment, it simply opens the file at the start and closes it at
> the end. So add two new local functions the way the trace code is doing
> it and have them figure out whether to write the output to stdout or the
> specified file. Then convert all existing output in the profile code to
> use these helpers.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> 2010-04-21 Mike Frysinger <vapier@gentoo.org>
>
> * sim-profile.c (profile_vprintf, profile_printf): New functions.
> (profile_print_pc): Convert sim_io_printf to profile_printf.
> (profile_print_insn): Likewise.
> (profile_print_memory): Likewise.
> (profile_print_core): Likewise.
> (profile_print_model): Likewise.
> (sim_profile_print_bar): Likewise.
> (profile_print_speed): Likewise.
> (profile_print_addr_ranges): Likewise.
> (profile_info): Likewise.
> * sim-profile.h (sim_profile_print_bar): Add cpu argument.
>
This patch is ok.
Thanks!
next prev parent reply other threads:[~2010-04-21 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 20:49 Mike Frysinger
2010-04-21 22:36 ` Doug Evans [this message]
2010-04-22 0:26 ` Mike Frysinger
2010-04-22 0:39 ` Mike Frysinger
2010-04-22 1:36 ` Doug Evans
2010-04-22 1:49 ` Hans-Peter Nilsson
2010-04-22 2:17 ` Mike Frysinger
2010-04-22 2:45 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2we394668d1004211536qa59e2d2amda0db99f2bac4413@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox