From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72408-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4370 invoked by alias); 22 Apr 2010 01:49:43 -0000
Received: (qmail 4325 invoked by uid 22791); 22 Apr 2010 01:49:41 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00
X-Spam-Check-By: sourceware.org
Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49)     by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Thu, 22 Apr 2010 01:49:36 +0000
Received: (qmail 91412 invoked by uid 20157); 22 Apr 2010 01:49:34 -0000
Received: from localhost (sendmail-bs@127.0.0.1)   by localhost with SMTP; 22 Apr 2010 01:49:34 -0000
Date: Thu, 22 Apr 2010 01:49:00 -0000
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Mike Frysinger <vapier@gentoo.org>
cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: profile: implement --profile-file backend
In-Reply-To: <201004212039.35705.vapier@gentoo.org>
Message-ID: <alpine.BSF.2.00.1004212143050.79451@dair.pair.com>
References: <1271882917-28580-1-git-send-email-vapier@gentoo.org> <m2we394668d1004211536qa59e2d2amda0db99f2bac4413@mail.gmail.com> <201004212027.01906.vapier@gentoo.org> <201004212039.35705.vapier@gentoo.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00727.txt.bz2

On Wed, 21 Apr 2010, Mike Frysinger wrote:
> sorry, i noticed i need these two fixes for some ports.  the ones i was build
> testing worked, but i wrote a small helper script to build all of them and
> noticed the problem.  wish sim had a --enable-targets=all option like gdb, but
> in the mean time, i'll stick with this script for future patches.
> -mike
>
> sim/frv/:
> 2010-04-21  Mike Frysinger  <vapier@gentoo.org>
>
> 	* profile.c (sim_profile_print_bar): Add cpu argument.

Please be much more careful when you test your patches.
(I think you forgot to run your script. ;)

Building all simulators seems reasonable to me, even so to test
those with test-suites (though it requires building binutils,
which thankfully can be checked out in the same source-tree).

Your change broke at least cris-elf, iq2000-elf and m32r-elf,
as you didn't adjust calls in sim/common/cgen-scache.c.

brgds, H-P