From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25308 invoked by alias); 22 Apr 2010 01:36:07 -0000 Received: (qmail 25287 invoked by uid 22791); 22 Apr 2010 01:36:03 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SARE_MSGID_LONG45,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 01:35:59 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id o3M1Ztm6028194 for ; Thu, 22 Apr 2010 03:35:56 +0200 Received: from pxi13 (pxi13.prod.google.com [10.243.27.13]) by kpbe16.cbf.corp.google.com with ESMTP id o3M1ZroQ020757 for ; Wed, 21 Apr 2010 18:35:54 -0700 Received: by pxi13 with SMTP id 13so573711pxi.23 for ; Wed, 21 Apr 2010 18:35:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.91.13 with HTTP; Wed, 21 Apr 2010 18:35:53 -0700 (PDT) In-Reply-To: <201004212039.35705.vapier@gentoo.org> References: <1271882917-28580-1-git-send-email-vapier@gentoo.org> <201004212027.01906.vapier@gentoo.org> <201004212039.35705.vapier@gentoo.org> Date: Thu, 22 Apr 2010 01:36:00 -0000 Received: by 10.141.4.9 with SMTP id g9mr1376176rvi.232.1271900153351; Wed, 21 Apr 2010 18:35:53 -0700 (PDT) Message-ID: Subject: Re: [PATCH] sim: profile: implement --profile-file backend From: Doug Evans To: Mike Frysinger Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00726.txt.bz2 On Wed, Apr 21, 2010 at 5:39 PM, Mike Frysinger wrote: > sorry, i noticed i need these two fixes for some ports. =A0the ones i was= build > testing worked, but i wrote a small helper script to build all of them and > noticed the problem. =A0wish sim had a --enable-targets=3Dall option like= gdb, but > in the mean time, i'll stick with this script for future patches. > -mike > > sim/frv/: > 2010-04-21 =A0Mike Frysinger =A0 > > =A0 =A0 =A0 =A0* profile.c (sim_profile_print_bar): Add cpu argument. > > RCS file: /cvs/src/src/sim/frv/profile.c,v > retrieving revision 1.11 > diff -u -p -r1.11 profile.c > --- sim/frv/profile.c =A0 1 Jan 2010 10:03:29 -0000 =A0 =A0 =A0 1.11 > +++ sim/frv/profile.c =A0 22 Apr 2010 00:34:57 -0000 > @@ -2042,7 +2042,7 @@ print_parallel (SIM_CPU *cpu, int verbos > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 max_name_= len, slot_names[i], > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 max_val <= 10000 ? 5 : 10, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 COMMAS (I= NSNS_IN_SLOT (i))); > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 sim_profile_print_bar (sd, PROFILE_HIST= OGRAM_WIDTH, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 sim_profile_print_bar (sd, cpu, PROFILE= _HISTOGRAM_WIDTH, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 INSNS_IN_SLOT (i), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 max_val); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sim_io_printf (sd, "\n"); > > sim/common/: > 2010-04-21 =A0Mike Frysinger =A0 > > =A0 =A0 =A0 =A0* sim-profile.h (sim_profile_print_bar): Use sim_cpu, not = SIM_CPU. > > RCS file: /cvs/src/src/sim/common/sim-profile.h,v > retrieving revision 1.10 > diff -u -p -r1.10 sim-profile.h > --- sim/common/sim-profile.h =A0 =A022 Apr 2010 00:26:08 -0000 =A0 =A0 = =A01.10 > +++ sim/common/sim-profile.h =A0 =A022 Apr 2010 00:36:05 -0000 > @@ -308,6 +308,6 @@ do { \ > > =A0/* Misc. utilities. =A0*/ > > -extern void sim_profile_print_bar (SIM_DESC, SIM_CPU *, unsigned int, un= signed int, unsigned int); > +extern void sim_profile_print_bar (SIM_DESC, sim_cpu *, unsigned int, un= signed int, unsigned int); > > =A0#endif /* SIM_PROFILE_H */ > Sure, no problem.