From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, jkratoch@redhat.com (Jan Kratochvil)
Subject: Re: [rfc] Infrastructure to disable breakpoints during inferior startup
Date: Thu, 23 Jul 2009 16:51:00 -0000 [thread overview]
Message-ID: <m3y6qfbj24.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200907231224.n6NCOlAH001392@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Thu\, 23 Jul 2009 14\:24\:47 +0200 \(CEST\)")
Ulrich> Yes, it's the same concept, but those functions in the PIE patch have
Ulrich> some code that seems PIE specific (e.g. the entry point checks) that
Ulrich> should be moved to the caller (presumably solib-svr4.c in the PIE case)
Ulrich> to make the same infrastructure usable for both scenarios.
Yeah, I agree.
Ulrich> (In any case, moving this variable over to a struct inferior field
Ulrich> can be trivially done after Pedro's patches are merged; I'm not sure
Ulrich> we have to wait because of that ...)
I'm inclined to agree as a general rule that we shouldn't put too much
work into helping out uncommitted patches. In this case, though, we do
already have struct inferior, and I wonder if the seemingly steady
stream of needed fixes is making Pedro's to-do list impossible.
I suppose if he doesn't speak up then I won't object any more :-)
Ulrich> Unless I'm missing someting, the array in
Ulrich> print_one_breakpoint_location is about enum bptype member; I've
Ulrich> added a enum enable_state member here ...
Yes, my mistake. I frequently get confused since both sets of constants
start with `bp_'.
Tom
next prev parent reply other threads:[~2009-07-23 15:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 17:14 Ulrich Weigand
2009-07-22 20:32 ` Tom Tromey
2009-07-23 15:49 ` Ulrich Weigand
2009-07-23 16:51 ` Tom Tromey [this message]
2009-07-23 18:06 ` Ulrich Weigand
2009-07-23 18:57 ` Pedro Alves
2009-07-24 22:49 ` Tom Tromey
2009-07-24 23:32 ` Multi-exec patches (Was: [rfc] Infrastructure to disable breakpoints during inferior startup) Tom Tromey
2009-07-25 16:05 ` Pedro Alves
2009-07-25 19:31 ` Pedro Alves
2009-07-27 17:39 ` Multi-exec patches Tom Tromey
2009-07-27 18:45 ` Tom Tromey
2009-07-28 14:28 ` Pedro Alves
2009-07-29 22:03 ` Tom Tromey
2009-07-31 15:45 ` [rfc] Infrastructure to disable breakpoints during inferior startup Ulrich Weigand
2009-08-03 3:07 ` Thiago Jung Bauermann
2009-08-03 18:13 ` Eli Zaretskii
2009-08-05 18:14 ` Ulrich Weigand
2009-08-05 18:58 ` Eli Zaretskii
2009-08-06 17:46 ` Tom Tromey
2009-08-06 18:42 ` Eli Zaretskii
2009-08-06 19:12 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6qfbj24.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jkratoch@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox