Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>,
	 tromey@redhat.com,  Jan Kratochvil <jkratoch@redhat.com>
Subject: Re: [rfc] Infrastructure to disable breakpoints during inferior startup
Date: Thu, 23 Jul 2009 18:57:00 -0000	[thread overview]
Message-ID: <200907231751.01413.pedro@codesourcery.com> (raw)
In-Reply-To: <200907231631.n6NGV2xR018887@d12av02.megacenter.de.ibm.com>

On Thursday 23 July 2009 17:31:02, Ulrich Weigand wrote:

> Thinking about it a bit more, it seems that in the context of Pedro's
> patches, this flag really needs to be a symbol-space property, not an
> inferior property: it basically says that objfiles in this symbol
> space have not yet been relocated to their final addresses and therefore
> cannot be used to determine breakpoint addresses.
> 
> In the situation where multiple inferiors potentially share a symbol
> space, this property applies to all of them.  Also, with Pedro's
> patches breakpoints will be per-symbol-space, not per-inferior, so
> we'll have to disable/re-enable all breakpoints in a given symbol
> space (we cannot really disable all breakpoints of a given inferior,
> as this information is not actually known).
> 
> So it seems that after all adding the flag to struct inferior now
> might be a step in the wrong direction; it should instead be added to
> struct symbol_space once Pedro's patches are in.
> 
> Pedro, any comments?

Yes, I agree with you.  (although in the only target supporting
shared symbol space, DICOS, we don't run or start programs, we only
attach to already running ones, and if we did [it would be possible to
add such feature], the code is always already all relocated when we
connect --- due to the global shared libraries feature of DICOS.)

While Tom's right, there has been a stream of changes recently that
constantly require that I adjust the multi-exec patch set, I'll handle
this one easily when your patch is in; I don't think it will
be much trouble.

BTW, I haven't had much of a chance to touch the multi-exec
patches since I posted them last.  I was mostly waiting to see if
people had comments on the general design, and on the user
interface before proceeding further with it.  If there's anything
I should do to make that (testing, review, comments) easier on
others, please let me know.

-- 
Pedro Alves


  reply	other threads:[~2009-07-23 16:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 17:14 Ulrich Weigand
2009-07-22 20:32 ` Tom Tromey
2009-07-23 15:49   ` Ulrich Weigand
2009-07-23 16:51     ` Tom Tromey
2009-07-23 18:06       ` Ulrich Weigand
2009-07-23 18:57         ` Pedro Alves [this message]
2009-07-24 22:49           ` Tom Tromey
2009-07-24 23:32             ` Multi-exec patches (Was: [rfc] Infrastructure to disable breakpoints during inferior startup) Tom Tromey
2009-07-25 16:05               ` Pedro Alves
2009-07-25 19:31                 ` Pedro Alves
2009-07-27 17:39                 ` Multi-exec patches Tom Tromey
2009-07-27 18:45                   ` Tom Tromey
2009-07-28 14:28                   ` Pedro Alves
2009-07-29 22:03                     ` Tom Tromey
2009-07-31 15:45           ` [rfc] Infrastructure to disable breakpoints during inferior startup Ulrich Weigand
2009-08-03  3:07             ` Thiago Jung Bauermann
2009-08-03 18:13               ` Eli Zaretskii
2009-08-05 18:14                 ` Ulrich Weigand
2009-08-05 18:58                   ` Eli Zaretskii
2009-08-06 17:46                   ` Tom Tromey
2009-08-06 18:42                     ` Eli Zaretskii
2009-08-06 19:12                       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907231751.01413.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jkratoch@redhat.com \
    --cc=tromey@redhat.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox