Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for gdb.base/solib-disc.exp  [Re: Regression for gdb.mi/mi-nsmoribund.exp]
Date: Wed, 25 Jan 2012 17:09:00 -0000	[thread overview]
Message-ID: <m3y5sv3gas.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120125110632.GA17295@host2.jankratochvil.net> (Jan	Kratochvil's message of "Wed, 25 Jan 2012 12:06:33 +0100")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> And with gdbserver it is regressing:
Jan> -PASS: gdb.base/solib-disc.exp: continue to load
Jan> +FAIL: gdb.base/solib-disc.exp: continue to load
Jan> -PASS: gdb.base/solib-disc.exp: continue to unload
Jan> +FAIL: gdb.base/solib-disc.exp: continue to unload

Here is the patch I am checking in.

The problem was just that the regexps needed updating.

Jan> I cannot evaluate the full testsuite results these days due to pending:
Jan> 	Performance regression (12x): Re: RFC: add relative file name
Jan> handling for linespecs
Jan> 	http://sourceware.org/ml/gdb-patches/2012-01/msg00697.html

This is next on my list.

Tom

2012-01-25  Tom Tromey  <tromey@redhat.com>

	* gdb.base/solib-disc.exp: Fix regexps.

diff --git a/gdb/testsuite/gdb.base/solib-disc.exp b/gdb/testsuite/gdb.base/solib-disc.exp
index e0d4875..0b1e9e7 100644
--- a/gdb/testsuite/gdb.base/solib-disc.exp
+++ b/gdb/testsuite/gdb.base/solib-disc.exp
@@ -62,7 +62,7 @@ if ![runto_main] then {
 
 gdb_test_no_output "set stop-on-solib-events 1"
 
-gdb_test "continue" "Stopped due to shared library event" "continue to load"
+gdb_test "continue" "Stopped due to shared library event.*" "continue to load"
 
 set msg "save \$pc after load"
 set saved_pc ""
@@ -84,7 +84,7 @@ if { [gdb_reconnect] == 0 } {
 gdb_test "print/x \$pc" "\\\$$decimal = $saved_pc" "check \$pc after load"
 
 
-gdb_test "continue" "Stopped due to shared library event" "continue to unload"
+gdb_test "continue" "Stopped due to shared library event.*" "continue to unload"
 
 set msg "save \$pc after unload"
 set saved_pc ""


  reply	other threads:[~2012-01-25 16:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 21:03 [4/4] RFC: implement catch load and catch unload Tom Tromey
2012-01-19 22:04 ` Eli Zaretskii
2012-01-20 15:12   ` Tom Tromey
2012-01-20 17:40 ` Pedro Alves
2012-01-24 17:31   ` Tom Tromey
2012-01-24 19:40     ` Pedro Alves
2012-01-20 17:44 ` Yao Qi
2012-01-20 19:45 ` Pedro Alves
2012-01-24 17:07   ` Tom Tromey
2012-01-24 17:28     ` Marc Khouzam
2012-01-24 18:25       ` Tom Tromey
2012-01-24 18:32         ` Marc Khouzam
2012-01-24 19:15           ` Tom Tromey
2012-01-24 20:36             ` Marc Khouzam
2012-01-24 17:22   ` Tom Tromey
2012-01-24 19:17     ` Pedro Alves
2012-01-24 22:11 ` Tom Tromey
2012-01-25 11:06   ` Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload] Jan Kratochvil
2012-01-25 11:18     ` Regression for gdb.base/solib-disc.exp [Re: Regression for gdb.mi/mi-nsmoribund.exp] Jan Kratochvil
2012-01-25 17:09       ` Tom Tromey [this message]
2012-01-25 17:27         ` Jan Kratochvil
2012-01-25 16:20     ` Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload] Tom Tromey
2012-02-20  8:28   ` [commit] catch-load.exp: Fix racy FAILs " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y5sv3gas.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox