From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13751 invoked by alias); 25 Jan 2012 16:20:35 -0000 Received: (qmail 13605 invoked by uid 22791); 25 Jan 2012 16:20:31 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jan 2012 16:20:14 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0PGKEYD023564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Jan 2012 11:20:14 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0PGKDYo011796; Wed, 25 Jan 2012 11:20:13 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0PGKBk8006528; Wed, 25 Jan 2012 11:20:12 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Regression for gdb.base/solib-disc.exp [Re: Regression for gdb.mi/mi-nsmoribund.exp] References: <20120125110312.GA17079@host2.jankratochvil.net> <20120125110632.GA17295@host2.jankratochvil.net> Date: Wed, 25 Jan 2012 17:09:00 -0000 In-Reply-To: <20120125110632.GA17295@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 25 Jan 2012 12:06:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00867.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> And with gdbserver it is regressing: Jan> -PASS: gdb.base/solib-disc.exp: continue to load Jan> +FAIL: gdb.base/solib-disc.exp: continue to load Jan> -PASS: gdb.base/solib-disc.exp: continue to unload Jan> +FAIL: gdb.base/solib-disc.exp: continue to unload Here is the patch I am checking in. The problem was just that the regexps needed updating. Jan> I cannot evaluate the full testsuite results these days due to pending: Jan> Performance regression (12x): Re: RFC: add relative file name Jan> handling for linespecs Jan> http://sourceware.org/ml/gdb-patches/2012-01/msg00697.html This is next on my list. Tom 2012-01-25 Tom Tromey * gdb.base/solib-disc.exp: Fix regexps. diff --git a/gdb/testsuite/gdb.base/solib-disc.exp b/gdb/testsuite/gdb.base/solib-disc.exp index e0d4875..0b1e9e7 100644 --- a/gdb/testsuite/gdb.base/solib-disc.exp +++ b/gdb/testsuite/gdb.base/solib-disc.exp @@ -62,7 +62,7 @@ if ![runto_main] then { gdb_test_no_output "set stop-on-solib-events 1" -gdb_test "continue" "Stopped due to shared library event" "continue to load" +gdb_test "continue" "Stopped due to shared library event.*" "continue to load" set msg "save \$pc after load" set saved_pc "" @@ -84,7 +84,7 @@ if { [gdb_reconnect] == 0 } { gdb_test "print/x \$pc" "\\\$$decimal = $saved_pc" "check \$pc after load" -gdb_test "continue" "Stopped due to shared library event" "continue to unload" +gdb_test "continue" "Stopped due to shared library event.*" "continue to unload" set msg "save \$pc after unload" set saved_pc ""