Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [4/4] RFC: implement catch load and catch unload
Date: Thu, 19 Jan 2012 22:04:00 -0000	[thread overview]
Message-ID: <83lip34axc.fsf@gnu.org> (raw)
In-Reply-To: <m3d3afxweq.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 19 Jan 2012 13:35:57 -0700
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -28,6 +28,11 @@
>    now set a breakpoint in build/gcc/expr.c, but not
>    build/libcpp/expr.c.
>  
> +* New commands
> +
> +  ** "catch load" and "catch unload" can be used to stop when a shared
> +     library is loaded or unloaded, respectively.
> +

This part is okay.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This part is also okay, but I have one minor comment:

> +@item load @r{[}regexp@r{]}
> +@itemx unload @r{[}regexp@r{]}
> +The loading or unloading of a shared library.  If @var{regexp} is
> +given, then the catchpoint will stop only if it matches one of the
> +affected libraries.                          ^^

That "it" in the last sentence is ambiguous: can be interpreted to
reference the catchpoint instead of the regexp.  How about replacing
it with "the regular expression"?

Thanks.


  reply	other threads:[~2012-01-19 21:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 21:03 Tom Tromey
2012-01-19 22:04 ` Eli Zaretskii [this message]
2012-01-20 15:12   ` Tom Tromey
2012-01-20 17:40 ` Pedro Alves
2012-01-24 17:31   ` Tom Tromey
2012-01-24 19:40     ` Pedro Alves
2012-01-20 17:44 ` Yao Qi
2012-01-20 19:45 ` Pedro Alves
2012-01-24 17:07   ` Tom Tromey
2012-01-24 17:28     ` Marc Khouzam
2012-01-24 18:25       ` Tom Tromey
2012-01-24 18:32         ` Marc Khouzam
2012-01-24 19:15           ` Tom Tromey
2012-01-24 20:36             ` Marc Khouzam
2012-01-24 17:22   ` Tom Tromey
2012-01-24 19:17     ` Pedro Alves
2012-01-24 22:11 ` Tom Tromey
2012-01-25 11:06   ` Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload] Jan Kratochvil
2012-01-25 11:18     ` Regression for gdb.base/solib-disc.exp [Re: Regression for gdb.mi/mi-nsmoribund.exp] Jan Kratochvil
2012-01-25 17:09       ` Tom Tromey
2012-01-25 17:27         ` Jan Kratochvil
2012-01-25 16:20     ` Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload] Tom Tromey
2012-02-20  8:28   ` [commit] catch-load.exp: Fix racy FAILs " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lip34axc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox