From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload]
Date: Wed, 25 Jan 2012 16:20:00 -0000 [thread overview]
Message-ID: <m3fwf36ais.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120125110312.GA17079@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 25 Jan 2012 12:03:12 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> commit 23be81b20039c057ad0af30082f6f8a16a7643e9
Jan> Author: Tom Tromey <tromey@redhat.com>
Jan> Date: Tue Jan 24 21:39:14 2012 +0000
Jan> PR symtab/12406:
Jan> It is crashing on all the tested Fedora distros for:
Jan> gdb.mi/mi-nsmoribund.exp
Here's the fix.
Built and regtested on x86-64 F15.
Tom
2012-01-25 Tom Tromey <tromey@redhat.com>
* breakpoint.c (bpstat_stop_status): Check 'breakpoint_at' before
dereferencing.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0da099b..ec7f348 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -4303,7 +4303,7 @@ bpstat_stop_status (struct address_space *aspace,
"catch unload". */
for (bs = bs_head; bs != NULL; bs = bs->next)
{
- if (bs->breakpoint_at->type == bp_shlib_event)
+ if (bs->breakpoint_at && bs->breakpoint_at->type == bp_shlib_event)
{
handle_solib_event ();
break;
next prev parent reply other threads:[~2012-01-25 15:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 21:03 [4/4] RFC: implement catch load and catch unload Tom Tromey
2012-01-19 22:04 ` Eli Zaretskii
2012-01-20 15:12 ` Tom Tromey
2012-01-20 17:40 ` Pedro Alves
2012-01-24 17:31 ` Tom Tromey
2012-01-24 19:40 ` Pedro Alves
2012-01-20 17:44 ` Yao Qi
2012-01-20 19:45 ` Pedro Alves
2012-01-24 17:07 ` Tom Tromey
2012-01-24 17:28 ` Marc Khouzam
2012-01-24 18:25 ` Tom Tromey
2012-01-24 18:32 ` Marc Khouzam
2012-01-24 19:15 ` Tom Tromey
2012-01-24 20:36 ` Marc Khouzam
2012-01-24 17:22 ` Tom Tromey
2012-01-24 19:17 ` Pedro Alves
2012-01-24 22:11 ` Tom Tromey
2012-01-25 11:06 ` Regression for gdb.mi/mi-nsmoribund.exp [Re: [4/4] RFC: implement catch load and catch unload] Jan Kratochvil
2012-01-25 11:18 ` Regression for gdb.base/solib-disc.exp [Re: Regression for gdb.mi/mi-nsmoribund.exp] Jan Kratochvil
2012-01-25 17:09 ` Tom Tromey
2012-01-25 17:27 ` Jan Kratochvil
2012-01-25 16:20 ` Tom Tromey [this message]
2012-02-20 8:28 ` [commit] catch-load.exp: Fix racy FAILs [Re: [4/4] RFC: implement catch load and catch unload] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwf36ais.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox