From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87469-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1637 invoked by alias); 25 Jan 2012 15:57:06 -0000
Received: (qmail 1612 invoked by uid 22791); 25 Jan 2012 15:57:05 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jan 2012 15:56:46 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0PFukET005712	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 25 Jan 2012 10:56:46 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0PFujA4032513;	Wed, 25 Jan 2012 10:56:46 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0PFuiOg002616;	Wed, 25 Jan 2012 10:56:44 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for gdb.mi/mi-nsmoribund.exp  [Re: [4/4] RFC: implement catch load and catch unload]
References: <m3d3afxweq.fsf@fleche.redhat.com>	<m3ipk09416.fsf@fleche.redhat.com>	<20120125110312.GA17079@host2.jankratochvil.net>
Date: Wed, 25 Jan 2012 16:20:00 -0000
In-Reply-To: <20120125110312.GA17079@host2.jankratochvil.net> (Jan	Kratochvil's message of "Wed, 25 Jan 2012 12:03:12 +0100")
Message-ID: <m3fwf36ais.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00866.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> commit 23be81b20039c057ad0af30082f6f8a16a7643e9
Jan> Author: Tom Tromey <tromey@redhat.com>
Jan> Date:   Tue Jan 24 21:39:14 2012 +0000
Jan>         PR symtab/12406:

Jan> It is crashing on all the tested Fedora distros for:
Jan> 	gdb.mi/mi-nsmoribund.exp

Here's the fix.

Built and regtested on x86-64 F15.

Tom

2012-01-25  Tom Tromey  <tromey@redhat.com>

	* breakpoint.c (bpstat_stop_status): Check 'breakpoint_at' before
	dereferencing.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0da099b..ec7f348 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -4303,7 +4303,7 @@ bpstat_stop_status (struct address_space *aspace,
      "catch unload".  */
   for (bs = bs_head; bs != NULL; bs = bs->next)
     {
-      if (bs->breakpoint_at->type == bp_shlib_event)
+      if (bs->breakpoint_at && bs->breakpoint_at->type == bp_shlib_event)
 	{
 	  handle_solib_event ();
 	  break;