[commit] catch-load.exp: Fix racy FAILs [Re: [4/4] RFC: implement catch load and catch unload]

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Tue, 24 Jan 2012 22:36:21 +0100, Tom Tromey wrote:
> gdb/testsuite
> 	* gdb.base/catch-load.exp: New file.

 catch unload zardoz
 Catchpoint 3 (unload)
 (gdb) PASS: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: catch unload zardoz
 continue
 Continuing.
 Stopped due to shared library event (no libraries added or removed)
-(gdb) continue
-Continuing.
-Stopped due to shared library event:
-  Inferior loaded gdb/testsuite.unix.-m32/gdb.base/catch-load-so.so
-(gdb) PASS: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: continue
+c(gdb) FAIL: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: continue
 testcase gdb/testsuite/gdb.base/catch-load.exp completed in 18 seconds

Checked in, it looks to me like an obvious duplicate entry there.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2012-02/msg00112.html

--- src/gdb/testsuite/ChangeLog	2012/02/19 13:05:27	1.3079
+++ src/gdb/testsuite/ChangeLog	2012/02/20 06:20:27	1.3080
@@ -1,3 +1,9 @@
+2012-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix racy FAILs.
+	* gdb.base/catch-load.exp (one_catch_load_test): Remove duplicate
+	"continue" command.
+
 2012-02-19  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Fix for gdbserver non-extended mode.
--- src/gdb/testsuite/gdb.base/catch-load.exp	2012/01/24 21:39:18	1.1
+++ src/gdb/testsuite/gdb.base/catch-load.exp	2012/02/20 06:20:28	1.2
@@ -68,7 +68,6 @@
     gdb_test_no_output "set stop-on-solib-events $sostop"
     gdb_test "catch $kind" "Catchpoint $decimal \\(.*\\)"
 
-    send_gdb "continue\n"
     gdb_test_multiple "continue" "continue" {
 	-re "Catchpoint $decimal\r\n.*loaded .*/$testfile2.*\r\n.*$gdb_prompt $" {
 	    if {$match} {