From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12002 invoked by alias); 20 Feb 2012 06:22:10 -0000 Received: (qmail 11979 invoked by uid 22791); 20 Feb 2012 06:22:09 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Feb 2012 06:21:52 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1K6Lqiw018291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Feb 2012 01:21:52 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1K6LmXf031393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 20 Feb 2012 01:21:51 -0500 Date: Mon, 20 Feb 2012 08:28:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [commit] catch-load.exp: Fix racy FAILs [Re: [4/4] RFC: implement catch load and catch unload] Message-ID: <20120220062147.GA5193@host2.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00394.txt.bz2 On Tue, 24 Jan 2012 22:36:21 +0100, Tom Tromey wrote: > gdb/testsuite > * gdb.base/catch-load.exp: New file. catch unload zardoz Catchpoint 3 (unload) (gdb) PASS: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: catch unload zardoz continue Continuing. Stopped due to shared library event (no libraries added or removed) -(gdb) continue -Continuing. -Stopped due to shared library event: - Inferior loaded gdb/testsuite.unix.-m32/gdb.base/catch-load-so.so -(gdb) PASS: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: continue +c(gdb) FAIL: gdb.base/catch-load.exp:non-matching unload with stop-on-solib-events: continue testcase gdb/testsuite/gdb.base/catch-load.exp completed in 18 seconds Checked in, it looks to me like an obvious duplicate entry there. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2012-02/msg00112.html --- src/gdb/testsuite/ChangeLog 2012/02/19 13:05:27 1.3079 +++ src/gdb/testsuite/ChangeLog 2012/02/20 06:20:27 1.3080 @@ -1,3 +1,9 @@ +2012-02-20 Jan Kratochvil + + Fix racy FAILs. + * gdb.base/catch-load.exp (one_catch_load_test): Remove duplicate + "continue" command. + 2012-02-19 Jan Kratochvil Fix for gdbserver non-extended mode. --- src/gdb/testsuite/gdb.base/catch-load.exp 2012/01/24 21:39:18 1.1 +++ src/gdb/testsuite/gdb.base/catch-load.exp 2012/02/20 06:20:28 1.2 @@ -68,7 +68,6 @@ gdb_test_no_output "set stop-on-solib-events $sostop" gdb_test "catch $kind" "Catchpoint $decimal \\(.*\\)" - send_gdb "continue\n" gdb_test_multiple "continue" "continue" { -re "Catchpoint $decimal\r\n.*loaded .*/$testfile2.*\r\n.*$gdb_prompt $" { if {$match} {