From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87321-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12948 invoked by alias); 19 Jan 2012 21:53:06 -0000
Received: (qmail 12934 invoked by uid 22791); 19 Jan 2012 21:53:05 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 21:52:51 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LY200F00FC0RR00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 19 Jan 2012 23:52:49 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.229.115.9]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LY200FBPFFZB7A0@a-mtaout20.012.net.il>; Thu, 19 Jan 2012 23:52:48 +0200 (IST)
Date: Thu, 19 Jan 2012 22:04:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [4/4] RFC: implement catch load and catch unload
In-reply-to: <m3d3afxweq.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83lip34axc.fsf@gnu.org>
References: <m3d3afxweq.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00718.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 19 Jan 2012 13:35:57 -0700
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -28,6 +28,11 @@
>    now set a breakpoint in build/gcc/expr.c, but not
>    build/libcpp/expr.c.
>  
> +* New commands
> +
> +  ** "catch load" and "catch unload" can be used to stop when a shared
> +     library is loaded or unloaded, respectively.
> +

This part is okay.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This part is also okay, but I have one minor comment:

> +@item load @r{[}regexp@r{]}
> +@itemx unload @r{[}regexp@r{]}
> +The loading or unloading of a shared library.  If @var{regexp} is
> +given, then the catchpoint will stop only if it matches one of the
> +affected libraries.                          ^^

That "it" in the last sentence is ambiguous: can be interpreted to
reference the catchpoint instead of the regexp.  How about replacing
it with "the regular expression"?

Thanks.