Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: set multiple-symbol ask/cancel not working
Date: Tue, 29 Nov 2011 16:57:00 -0000	[thread overview]
Message-ID: <m3sjl6n9z6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3d3caoqiv.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue,	29 Nov 2011 09:13:44 -0700")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> Since the "canonical form" doesn't actually have to be valid input to
Tom> linespec (it is only used for filtering the results -- well, it is now
Tom> that I fixed a couple of bad uses), I went ahead and changed
Tom> linespec.c:add_sal_to_sals to use FILE:FUNCTION:LINE for the canonical
Tom> form in this case.

Tom> This gives:

Tom> (gdb) b pck.adb:normal_Menu
Tom> [0] cancel
Tom> [1] all
Tom> [2] pck.adb:pck.normal_menu:4
Tom> [3] pck.adb:pck.normal_menu:8

I am not at all sure about doing this.  It means that the breakpoint
will stop working if the line number changes.

Maybe this is ok, since it is what the user asked for in
multiple-symbols=ask mode -- not the default, so he essentially asked
twice.

Another option would be to only apply this treatment to Ada.

I'll send the current patches, with this in place, regardless.

Tom


  reply	other threads:[~2011-11-29 16:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 16:39 GDB 7.4 branching status? (2011-11-23) Joel Brobecker
2011-11-23 16:56 ` Tristan Gingold
2011-11-23 18:47 ` Tom Tromey
2011-11-23 23:24   ` Joel Brobecker
2011-11-24 10:56     ` Jerome Guitton
2011-11-24 16:33       ` Joel Brobecker
2011-11-28 16:17         ` Tom Tromey
2011-11-28 21:29         ` Tom Tromey
2011-11-29  2:28           ` Joel Brobecker
2011-11-29  2:49           ` iterate_over_symbols should be a wrapper? (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:27             ` iterate_over_symbols should be a wrapper? Tom Tromey
2011-11-29  3:07           ` partial-symtab symbol sorting (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29  8:41             ` Pierre Muller
2011-11-29 14:51             ` partial-symtab symbol sorting Tom Tromey
     [not found]             ` <47228.5772244961$1322556128@news.gmane.org>
2011-11-29 14:55               ` Tom Tromey
2011-11-29  3:11           ` multiple-location breakpoint output (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:06             ` multiple-location breakpoint output Tom Tromey
2011-11-29  3:14           ` decode_digits_line_mode (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 14:56             ` decode_digits_line_mode Tom Tromey
2011-11-29  3:19           ` [RFA/commit/testcase] "info line" should not skip prologues (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:03             ` [RFA/commit/testcase] "info line" should not skip prologues Tom Tromey
2011-11-29 17:00               ` Joel Brobecker
2011-11-29  3:22           ` GDB 7.4 branching status? (2011-11-23) Joel Brobecker
2011-11-29 15:38             ` Tom Tromey
2011-11-29  3:29           ` set multiple-symbol ask/cancel not working (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 16:14             ` set multiple-symbol ask/cancel not working Tom Tromey
2011-11-29 16:57               ` Tom Tromey [this message]
2011-11-29 17:06                 ` Joel Brobecker
2011-11-30 16:41                   ` Tom Tromey
2011-11-29  3:33           ` one-too-many location in breakpoint (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 16:15             ` one-too-many location in breakpoint Tom Tromey
2011-11-29 16:59               ` Tom Tromey
2011-11-30  5:59                 ` Joel Brobecker
2011-11-30 16:41                   ` Tom Tromey
2011-12-05 12:04                 ` Pedro Alves
2011-12-05 12:17                   ` Pedro Alves
2011-12-08 18:56                 ` Maciej W. Rozycki
2011-12-09  8:47                   ` Joel Brobecker
2011-11-24  0:58 ` GDB 7.4 branching status? (2011-11-23) Yao Qi
2011-11-24 17:17 ` Maciej W. Rozycki
2011-11-24 17:27   ` Joel Brobecker
2011-12-03  1:19     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sjl6n9z6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox