From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: one-too-many location in breakpoint
Date: Wed, 30 Nov 2011 16:41:00 -0000 [thread overview]
Message-ID: <m3liqximwa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111130055825.GV24943@adacore.com> (Joel Brobecker's message of "Tue, 29 Nov 2011 21:58:25 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> As discussed on IRC, there was one problem that I missed in the
Joel> proposals I made earlier. Attached is a patch that I wrote
Joel> which should solve that problem. In hindsight, perhaps I should
Joel> have split it in 2 or 3 patches, for instance one patch for
Joel> the new language method, and one patch for the rest.
I think one patch is fine. It is still easy to read.
Joel> With that patch, pretty much everything that I suggested, except
Joel> for the couple of issues I briefly mentioned (without describing
Joel> them), has been addressed. I'm not convinced yet that the remaining
Joel> issues have anything to do with the patch series but I will look
Joel> into that tomorrow.
The patch seems reasonable to me.
Joel> + make_cleanup (xfree, (void *) lookup_name);
You don't need the cast here.
Tom
next prev parent reply other threads:[~2011-11-30 16:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 16:39 GDB 7.4 branching status? (2011-11-23) Joel Brobecker
2011-11-23 16:56 ` Tristan Gingold
2011-11-23 18:47 ` Tom Tromey
2011-11-23 23:24 ` Joel Brobecker
2011-11-24 10:56 ` Jerome Guitton
2011-11-24 16:33 ` Joel Brobecker
2011-11-28 16:17 ` Tom Tromey
2011-11-28 21:29 ` Tom Tromey
2011-11-29 2:28 ` Joel Brobecker
2011-11-29 2:49 ` iterate_over_symbols should be a wrapper? (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:27 ` iterate_over_symbols should be a wrapper? Tom Tromey
2011-11-29 3:07 ` partial-symtab symbol sorting (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 8:41 ` Pierre Muller
2011-11-29 14:51 ` partial-symtab symbol sorting Tom Tromey
[not found] ` <47228.5772244961$1322556128@news.gmane.org>
2011-11-29 14:55 ` Tom Tromey
2011-11-29 3:11 ` multiple-location breakpoint output (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:06 ` multiple-location breakpoint output Tom Tromey
2011-11-29 3:14 ` decode_digits_line_mode (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 14:56 ` decode_digits_line_mode Tom Tromey
2011-11-29 3:19 ` [RFA/commit/testcase] "info line" should not skip prologues (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 15:03 ` [RFA/commit/testcase] "info line" should not skip prologues Tom Tromey
2011-11-29 17:00 ` Joel Brobecker
2011-11-29 3:22 ` GDB 7.4 branching status? (2011-11-23) Joel Brobecker
2011-11-29 15:38 ` Tom Tromey
2011-11-29 3:29 ` set multiple-symbol ask/cancel not working (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 16:14 ` set multiple-symbol ask/cancel not working Tom Tromey
2011-11-29 16:57 ` Tom Tromey
2011-11-29 17:06 ` Joel Brobecker
2011-11-30 16:41 ` Tom Tromey
2011-11-29 3:33 ` one-too-many location in breakpoint (was: "Re: GDB 7.4 branching status? (2011-11-23)") Joel Brobecker
2011-11-29 16:15 ` one-too-many location in breakpoint Tom Tromey
2011-11-29 16:59 ` Tom Tromey
2011-11-30 5:59 ` Joel Brobecker
2011-11-30 16:41 ` Tom Tromey [this message]
2011-12-05 12:04 ` Pedro Alves
2011-12-05 12:17 ` Pedro Alves
2011-12-08 18:56 ` Maciej W. Rozycki
2011-12-09 8:47 ` Joel Brobecker
2011-11-24 0:58 ` GDB 7.4 branching status? (2011-11-23) Yao Qi
2011-11-24 17:17 ` Maciej W. Rozycki
2011-11-24 17:27 ` Joel Brobecker
2011-12-03 1:19 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3liqximwa.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox