From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6795 invoked by alias); 30 Nov 2011 16:41:21 -0000 Received: (qmail 6601 invoked by uid 22791); 30 Nov 2011 16:41:15 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Nov 2011 16:40:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAUGevZD021424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Nov 2011 11:40:57 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAUGevc8006613; Wed, 30 Nov 2011 11:40:57 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAUGeriK009012; Wed, 30 Nov 2011 11:40:54 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: one-too-many location in breakpoint References: <20111123163917.GA13809@adacore.com> <20111123232406.GQ13809@adacore.com> <20111124105603.GA91879@adacore.com> <20111124163304.GR13809@adacore.com> <20111129033329.GS24943@adacore.com> <20111130055825.GV24943@adacore.com> Date: Wed, 30 Nov 2011 16:41:00 -0000 In-Reply-To: <20111130055825.GV24943@adacore.com> (Joel Brobecker's message of "Tue, 29 Nov 2011 21:58:25 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00848.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> As discussed on IRC, there was one problem that I missed in the Joel> proposals I made earlier. Attached is a patch that I wrote Joel> which should solve that problem. In hindsight, perhaps I should Joel> have split it in 2 or 3 patches, for instance one patch for Joel> the new language method, and one patch for the rest. I think one patch is fine. It is still easy to read. Joel> With that patch, pretty much everything that I suggested, except Joel> for the couple of issues I briefly mentioned (without describing Joel> them), has been addressed. I'm not convinced yet that the remaining Joel> issues have anything to do with the patch series but I will look Joel> into that tomorrow. The patch seems reasonable to me. Joel> + make_cleanup (xfree, (void *) lookup_name); You don't need the cast here. Tom