From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9185 invoked by alias); 29 Nov 2011 16:57:01 -0000 Received: (qmail 9149 invoked by uid 22791); 29 Nov 2011 16:56:57 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 16:56:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pATGuVBB012191 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 29 Nov 2011 11:56:31 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pATGuVEC019012; Tue, 29 Nov 2011 11:56:31 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pATGuTqi006318; Tue, 29 Nov 2011 11:56:30 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: set multiple-symbol ask/cancel not working References: <20111123163917.GA13809@adacore.com> <20111123232406.GQ13809@adacore.com> <20111124105603.GA91879@adacore.com> <20111124163304.GR13809@adacore.com> <20111129032917.GR24943@adacore.com> Date: Tue, 29 Nov 2011 16:57:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue, 29 Nov 2011 09:13:44 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00822.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Since the "canonical form" doesn't actually have to be valid input to Tom> linespec (it is only used for filtering the results -- well, it is now Tom> that I fixed a couple of bad uses), I went ahead and changed Tom> linespec.c:add_sal_to_sals to use FILE:FUNCTION:LINE for the canonical Tom> form in this case. Tom> This gives: Tom> (gdb) b pck.adb:normal_Menu Tom> [0] cancel Tom> [1] all Tom> [2] pck.adb:pck.normal_menu:4 Tom> [3] pck.adb:pck.normal_menu:8 I am not at all sure about doing this. It means that the breakpoint will stop working if the line number changes. Maybe this is ok, since it is what the user asked for in multiple-symbols=ask mode -- not the default, so he essentially asked twice. Another option would be to only apply this treatment to Ada. I'll send the current patches, with this in place, regardless. Tom