From: Tom Tromey <tromey@redhat.com>
To: Mihail Zenkov <mihail.zenkov@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: D language support
Date: Fri, 23 Apr 2010 18:11:00 -0000 [thread overview]
Message-ID: <m3iq7iyr8m.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100422045136.bc397747.mihai.zenkov@gmail.com> (Mihail Zenkov's message of "Thu, 22 Apr 2010 04:51:36 +0300")
>>>>> "Mihail" == Mihail Zenkov <mihail.zenkov@gmail.com> writes:
Style nits...
Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter);
Must split this line.
Mihail> +d_demangle (const char* symbol, int options)
"char *", not "char* ".
Mihail> + if (mangled_str[0] == '_' && mangled_str[1] == 'D')
Mihail> + {
Mihail> + mangled_str += 2;
Mihail> + is_func = 1;
Mihail> + }
Mihail> + else if (strncmp (mangled_str, "__Class_", 8) == 0)
Mihail> + mangled_str += 8;
Mihail> + else if (strncmp (mangled_str, "__init_", 7) == 0)
Mihail> + mangled_str += 7;
All the "else if"s are indented too far.
Tom
next prev parent reply other threads:[~2010-04-23 18:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 23:57 Mihail Zenkov
2009-12-30 12:56 ` Joel Brobecker
2010-01-09 6:25 ` Mihail Zenkov
2010-01-09 6:29 ` Mihail Zenkov
2010-01-09 14:23 ` Joel Brobecker
2010-01-13 4:42 ` Mihail Zenkov
2010-01-15 5:10 ` Joel Brobecker
2010-01-15 21:02 ` Tom Tromey
2010-01-15 21:05 ` Tom Tromey
2010-04-14 22:22 ` Mihail Zenkov
2010-04-20 21:39 ` Tom Tromey
2010-04-21 0:01 ` Mihail Zenkov
2010-04-21 15:57 ` Joel Brobecker
2010-04-22 0:11 ` Mihail Zenkov
2010-04-22 0:44 ` Joel Brobecker
2010-04-22 1:53 ` Mihail Zenkov
2010-04-23 18:11 ` Tom Tromey [this message]
2010-04-24 0:06 ` Mihail Zenkov
2010-04-27 16:05 ` Joel Brobecker
2010-04-27 23:55 ` Mihail Zenkov
2010-04-28 15:17 ` Joel Brobecker
2010-04-28 17:11 ` Eli Zaretskii
2010-04-29 2:16 ` Mihail Zenkov
2010-04-28 17:10 ` Eli Zaretskii
2010-04-29 1:59 ` Mihail Zenkov
2010-04-29 3:10 ` Eli Zaretskii
2010-04-29 14:47 ` Joel Brobecker
2010-04-23 18:09 ` Tom Tromey
2010-04-23 20:15 ` Leandro Lucarella
2010-04-23 20:37 ` Tom Tromey
2010-04-26 23:51 ` Stan Shebs
2010-04-27 0:29 ` Joel Brobecker
2010-04-23 21:35 ` Robert Clipsham
2010-04-24 0:26 ` Mihail Zenkov
2010-04-27 20:27 ` Robert Clipsham
-- strict thread matches above, loose matches on Subject: below --
2009-08-17 23:02 Mihail Zenkov
2009-08-18 4:18 ` Eli Zaretskii
2009-08-18 16:39 ` Tom Tromey
[not found] ` <20090818225844.GA9879@homero.springfield.home>
2009-08-19 18:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iq7iyr8m.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mihail.zenkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox