From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72489-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2103 invoked by alias); 23 Apr 2010 18:11:05 -0000
Received: (qmail 2090 invoked by uid 22791); 23 Apr 2010 18:11:03 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 18:10:59 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3NIAZJX015326 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 23 Apr 2010 14:10:35 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3NIAZXl022080; 	Fri, 23 Apr 2010 14:10:35 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3NIAYdC016722; 	Fri, 23 Apr 2010 14:10:34 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id D524137849C; Fri, 23 Apr 2010 12:10:33 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Mihail Zenkov <mihail.zenkov@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: D language support
References: <20100109082524.263bcb17.mihai.zenkov@gmail.com> 	<20100109082830.dd984de8.mihai.zenkov@gmail.com> 	<20100109142327.GC2007@adacore.com> 	<20100113064026.14f75ff2.mihai.zenkov@gmail.com> 	<m3ljfzaxlk.fsf@fleche.redhat.com> 	<20100415012124.91ce1769.mihai.zenkov@gmail.com> 	<m34oj5g5x6.fsf@fleche.redhat.com> 	<20100421025919.ad3a0830.mihai.zenkov@gmail.com> 	<20100421155657.GA19194@adacore.com> 	<20100422030910.7e84f7ea.mihai.zenkov@gmail.com> 	<20100422004441.GE19194@adacore.com> 	<20100422045136.bc397747.mihai.zenkov@gmail.com>
Reply-To: tromey@redhat.com
Date: Fri, 23 Apr 2010 18:11:00 -0000
In-Reply-To: <20100422045136.bc397747.mihai.zenkov@gmail.com> (Mihail Zenkov's 	message of "Thu, 22 Apr 2010 04:51:36 +0300")
Message-ID: <m3iq7iyr8m.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00808.txt.bz2

>>>>> "Mihail" == Mihail Zenkov <mihail.zenkov@gmail.com> writes:

Style nits...

Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter);

Must split this line.

Mihail> +d_demangle (const char* symbol, int options)

"char *", not "char* ".

Mihail> +  if (mangled_str[0] == '_' && mangled_str[1] == 'D')
Mihail> +    {
Mihail> +      mangled_str += 2;
Mihail> +      is_func = 1;
Mihail> +    }
Mihail> +    else if (strncmp (mangled_str, "__Class_", 8) == 0)
Mihail> +      mangled_str += 8;
Mihail> +    else if (strncmp (mangled_str, "__init_", 7) == 0)
Mihail> +      mangled_str += 7;

All the "else if"s are indented too far.

Tom