Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stan Shebs <stan@codesourcery.com>
To: tromey@redhat.com
Cc: Leandro Lucarella <llucax@gmail.com>, gdb-patches@sources.redhat.com
Subject: Re: D language support
Date: Mon, 26 Apr 2010 23:51:00 -0000	[thread overview]
Message-ID: <4BD62710.1050905@codesourcery.com> (raw)
In-Reply-To: <m3r5m5ykgl.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "Leandro" == Leandro Lucarella <llucax@gmail.com> writes:
>>>>>>             
>
> Leandro> Is the indent program invoked with -gnu option enough to fix the style
> Leandro> nits or GDB has its own rules? It might save some time to everybody =)
>
> Weirdly, indent -gnu doesn't really use the GNU style.
> It is a sort of approximation.
>
> We have a gdb_indent.sh in the tree, and I think it was used at one
> point, but in the end I think it was abandoned.  I think sometimes it
> did the wrong thing.
>   
To some extent, one just has to decide that the output of the script is 
"correct", even if it looks wrong here and there.  But I think part of 
the pain comes from having *two* programs - emacs and indent - that can 
have differing conclusions, and being unsure as to which should take 
precedence.

Somebody should give gdb_indent.sh a try, see how it does on today's 
sources.  We have more people participating in maintenance these days, 
seems like we could run it once a week or so, and it has the bonus of 
cleaning up after those rouge global maintainers who check in massive 
hacks willy-nilly. :-)

Stan


  reply	other threads:[~2010-04-26 23:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 23:57 Mihail Zenkov
2009-12-30 12:56 ` Joel Brobecker
2010-01-09  6:25   ` Mihail Zenkov
2010-01-09  6:29     ` Mihail Zenkov
2010-01-09 14:23       ` Joel Brobecker
2010-01-13  4:42         ` Mihail Zenkov
2010-01-15  5:10           ` Joel Brobecker
2010-01-15 21:02             ` Tom Tromey
2010-01-15 21:05           ` Tom Tromey
2010-04-14 22:22             ` Mihail Zenkov
2010-04-20 21:39               ` Tom Tromey
2010-04-21  0:01                 ` Mihail Zenkov
2010-04-21 15:57                   ` Joel Brobecker
2010-04-22  0:11                     ` Mihail Zenkov
2010-04-22  0:44                       ` Joel Brobecker
2010-04-22  1:53                         ` Mihail Zenkov
2010-04-23 18:11                           ` Tom Tromey
2010-04-24  0:06                             ` Mihail Zenkov
2010-04-27 16:05                               ` Joel Brobecker
2010-04-27 23:55                                 ` Mihail Zenkov
2010-04-28 15:17                                   ` Joel Brobecker
2010-04-28 17:11                                     ` Eli Zaretskii
2010-04-29  2:16                                     ` Mihail Zenkov
2010-04-28 17:10                                   ` Eli Zaretskii
2010-04-29  1:59                                     ` Mihail Zenkov
2010-04-29  3:10                                       ` Eli Zaretskii
2010-04-29 14:47                                       ` Joel Brobecker
2010-04-23 18:09                         ` Tom Tromey
2010-04-23 20:15                           ` Leandro Lucarella
2010-04-23 20:37                             ` Tom Tromey
2010-04-26 23:51                               ` Stan Shebs [this message]
2010-04-27  0:29                                 ` Joel Brobecker
2010-04-23 21:35               ` Robert Clipsham
2010-04-24  0:26                 ` Mihail Zenkov
2010-04-27 20:27                   ` Robert Clipsham
  -- strict thread matches above, loose matches on Subject: below --
2009-08-17 23:02 Mihail Zenkov
2009-08-18  4:18 ` Eli Zaretskii
2009-08-18 16:39 ` Tom Tromey
     [not found]   ` <20090818225844.GA9879@homero.springfield.home>
2009-08-19 18:36     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD62710.1050905@codesourcery.com \
    --to=stan@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=llucax@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox