From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20078 invoked by alias); 26 Apr 2010 23:51:56 -0000 Received: (qmail 20063 invoked by uid 22791); 26 Apr 2010 23:51:55 -0000 X-SWARE-Spam-Status: No, hits=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 23:51:51 +0000 Received: (qmail 25594 invoked from network); 26 Apr 2010 23:51:50 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Apr 2010 23:51:50 -0000 Message-ID: <4BD62710.1050905@codesourcery.com> Date: Mon, 26 Apr 2010 23:51:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: tromey@redhat.com CC: Leandro Lucarella , gdb-patches@sources.redhat.com Subject: Re: D language support References: <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <20100415012124.91ce1769.mihai.zenkov@gmail.com> <20100421025919.ad3a0830.mihai.zenkov@gmail.com> <20100421155657.GA19194@adacore.com> <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> <20100422004441.GE19194@adacore.com> <20100423193659.GA5342@llucax.com.ar> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00900.txt.bz2 Tom Tromey wrote: >>>>>> "Leandro" == Leandro Lucarella writes: >>>>>> > > Leandro> Is the indent program invoked with -gnu option enough to fix the style > Leandro> nits or GDB has its own rules? It might save some time to everybody =) > > Weirdly, indent -gnu doesn't really use the GNU style. > It is a sort of approximation. > > We have a gdb_indent.sh in the tree, and I think it was used at one > point, but in the end I think it was abandoned. I think sometimes it > did the wrong thing. > To some extent, one just has to decide that the output of the script is "correct", even if it looks wrong here and there. But I think part of the pain comes from having *two* programs - emacs and indent - that can have differing conclusions, and being unsure as to which should take precedence. Somebody should give gdb_indent.sh a try, see how it does on today's sources. We have more people participating in maintenance these days, seems like we could run it once a week or so, and it has the bonus of cleaning up after those rouge global maintainers who check in massive hacks willy-nilly. :-) Stan