Re: D language support

[Joel Brobecker <brobecker@adacore.com>]

> It not real global. As it static it visibility limited to current
> file. In this case we can think about this file as if it was C++
> class. IMHO it more easy readable code - we promptly see all function
> use same variables.

Although making the variable static limits the damage, I pretty strongly
disagree that having this inter-routine global makes the code more
readable. But, as I said, I don't see this as a blocking problem because
it's localized to an area that I hope will require little attention from
anyone but you; so I am happy to let it go provided that another Global
Maintainer says it's OK - I'll try to remember to ask Tom for his take
on it, if no one else provides an opinion...

> > > +  if (gsymbol->language == language_d
> > > +      || gsymbol->language == language_auto)
> > > +    {
> > > +      demangled =
> > > +	d_demangle(mangled, 0);
[...]
> Still i should join it?

Yes, please. It's not a matter of style for this line. In your case,
the whole statement fits in one line, and thus should be written as
such. For the cases you quoted, it did not, and thus the statement was
split across 2 or more lines...

-- 
Joel