Re: D language support

[Joel Brobecker <brobecker@adacore.com>]

Mihail,

> gdb/NEWS:
> * D language support.
>  Support for debugging the D programming language has been
>  integrated into GDB.
> gdb/ChangeLog:
> 	D language support.
> 	* Makefile.in (SFILES): Add d-lang.c d-valprint.c.
> 	(COMMON_OBS): Add d-lang.o d-valprint.o.
> 	(HFILES_NO_SRCDIR): Add d-lang.h.
> 	* c-lang.c (c_emit_char, exp_descriptor_c): Make public.
> 	* c-lang.h (c_emit_char, exp_descriptor_c): Add declaration.
> 	* d-lang.c: New file.
> 	* d-lang.h: New file.
> 	* d-valprint.c: New file.
> 	* defs.h (enum language): Add language_d.
> 	* dwarf2read.c (set_cu_language): Add DW_LANG_D.
> 	* language.c (binop_result_type, integral_type, character_type) 
> 	(string_type, boolean_type, structured_type): Add language_d.
> 	* symfile.c (init_filename_language_table): Add language_d.
> 	* symtab.c: Include d-lang.h.
> 	(symbol_init_language_specific, symbol_find_demangled_name)
> 	(symbol_natural_name, lookup_symbol_in_language)
> 	(symbol_demangled_name, symbol_matches_domain): Add language_d.
> gdb/doc/ChangeLog:
> 	* gdb.texinfo: Add mention about D language support.
> gdb/testsuite/ChangeLog:
> 	* gdb.base/default.exp: Fix "set language" test.

The patch is approved (good job!).

A couple of technical items:

  - Has the modification to gdb/NEWS been approved by Eli? If not,
    it has to be reviewed and approved by him.  Also, when you do
    commit the change, the NEWS file is similar to all other files,
    so it means that you have to send a diff, and provide a ChangeLog
    entry. Hence, the following...

         > gdb/NEWS:
         > * D language support.
         >  Support for debugging the D programming language has been
         >  integrated into GDB.

    ... does not follow the procedures (we don't know where you plan
    to insert this entry, for instance).

  - Now that you have submitted one good patch, you qualify for having
    write access to the GDB repository.  Should you be interested, let
    us know, and I'll send you some pointers.

-- 
Joel