From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17302 invoked by alias); 28 Apr 2010 15:17:29 -0000 Received: (qmail 17290 invoked by uid 22791); 28 Apr 2010 15:17:27 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Apr 2010 15:17:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 934B32BAB24; Wed, 28 Apr 2010 11:17:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id x5U3caExApWM; Wed, 28 Apr 2010 11:17:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 538F82BAB6E; Wed, 28 Apr 2010 11:17:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 279C8F5896; Wed, 28 Apr 2010 08:17:17 -0700 (PDT) Date: Wed, 28 Apr 2010 15:17:00 -0000 From: Joel Brobecker To: Mihail Zenkov Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: D language support Message-ID: <20100428151717.GI2951@adacore.com> References: <20100421025919.ad3a0830.mihai.zenkov@gmail.com> <20100421155657.GA19194@adacore.com> <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> <20100422004441.GE19194@adacore.com> <20100422045136.bc397747.mihai.zenkov@gmail.com> <20100424030441.81b6b66b.mihai.zenkov@gmail.com> <20100427160523.GD2951@adacore.com> <20100428025334.69e28794.mihai.zenkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100428025334.69e28794.mihai.zenkov@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00941.txt.bz2 Mihail, > gdb/NEWS: > * D language support. > Support for debugging the D programming language has been > integrated into GDB. > gdb/ChangeLog: > D language support. > * Makefile.in (SFILES): Add d-lang.c d-valprint.c. > (COMMON_OBS): Add d-lang.o d-valprint.o. > (HFILES_NO_SRCDIR): Add d-lang.h. > * c-lang.c (c_emit_char, exp_descriptor_c): Make public. > * c-lang.h (c_emit_char, exp_descriptor_c): Add declaration. > * d-lang.c: New file. > * d-lang.h: New file. > * d-valprint.c: New file. > * defs.h (enum language): Add language_d. > * dwarf2read.c (set_cu_language): Add DW_LANG_D. > * language.c (binop_result_type, integral_type, character_type) > (string_type, boolean_type, structured_type): Add language_d. > * symfile.c (init_filename_language_table): Add language_d. > * symtab.c: Include d-lang.h. > (symbol_init_language_specific, symbol_find_demangled_name) > (symbol_natural_name, lookup_symbol_in_language) > (symbol_demangled_name, symbol_matches_domain): Add language_d. > gdb/doc/ChangeLog: > * gdb.texinfo: Add mention about D language support. > gdb/testsuite/ChangeLog: > * gdb.base/default.exp: Fix "set language" test. The patch is approved (good job!). A couple of technical items: - Has the modification to gdb/NEWS been approved by Eli? If not, it has to be reviewed and approved by him. Also, when you do commit the change, the NEWS file is similar to all other files, so it means that you have to send a diff, and provide a ChangeLog entry. Hence, the following... > gdb/NEWS: > * D language support. > Support for debugging the D programming language has been > integrated into GDB. ... does not follow the procedures (we don't know where you plan to insert this entry, for instance). - Now that you have submitted one good patch, you qualify for having write access to the GDB repository. Should you be interested, let us know, and I'll send you some pointers. -- Joel