From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20933 invoked by alias); 22 Apr 2010 00:44:59 -0000 Received: (qmail 20894 invoked by uid 22791); 22 Apr 2010 00:44:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 00:44:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AB8B22BACC1; Wed, 21 Apr 2010 20:44:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JUg--Lfpvg7O; Wed, 21 Apr 2010 20:44:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 852B62BAC7D; Wed, 21 Apr 2010 20:44:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C22E3F5895; Wed, 21 Apr 2010 17:44:41 -0700 (PDT) Date: Thu, 22 Apr 2010 00:44:00 -0000 From: Joel Brobecker To: Mihail Zenkov Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: D language support Message-ID: <20100422004441.GE19194@adacore.com> References: <20100109082524.263bcb17.mihai.zenkov@gmail.com> <20100109082830.dd984de8.mihai.zenkov@gmail.com> <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <20100415012124.91ce1769.mihai.zenkov@gmail.com> <20100421025919.ad3a0830.mihai.zenkov@gmail.com> <20100421155657.GA19194@adacore.com> <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00724.txt.bz2 > It not real global. As it static it visibility limited to current > file. In this case we can think about this file as if it was C++ > class. IMHO it more easy readable code - we promptly see all function > use same variables. Although making the variable static limits the damage, I pretty strongly disagree that having this inter-routine global makes the code more readable. But, as I said, I don't see this as a blocking problem because it's localized to an area that I hope will require little attention from anyone but you; so I am happy to let it go provided that another Global Maintainer says it's OK - I'll try to remember to ask Tom for his take on it, if no one else provides an opinion... > > > + if (gsymbol->language == language_d > > > + || gsymbol->language == language_auto) > > > + { > > > + demangled = > > > + d_demangle(mangled, 0); [...] > Still i should join it? Yes, please. It's not a matter of style for this line. In your case, the whole statement fits in one line, and thus should be written as such. For the cases you quoted, it did not, and thus the statement was split across 2 or more lines... -- Joel