From: Phil Muldoon <pmuldoon@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] [python] Prompt substitution
Date: Tue, 30 Aug 2011 20:23:00 -0000 [thread overview]
Message-ID: <m3hb4yr6no.fsf@redhat.com> (raw)
In-Reply-To: <201108302018.03489.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 30 Aug 2011 20:18:03 +0100")
Pedro Alves <pedro@codesourcery.com> writes:
> I believe this to be a bit broken in the annotations (prefix and
> suffix != NULL) case. If the observer changes the prompt, we won't print
> either the prefix or the suffix, but will print directly what the
> observer on the prompt itself only (get_prompt).
Hmm, interesting. It passed the annotations tests :(
> I believe it was not intended for the hook to be able
> to override the prefix and the suffix as well. Right?
> I'm fixing this along with the get-rid-of-prompt-stack
> change.
Nope, not intended to do anything at all with prefix/suffix. AFAIK
prefix/suffix is only used in one particular case of annotations that
matter (basically the control characters that are printed in the
prefix/suffix when annotations > 1).
Anyway, thanks for taking care of this. And thanks for getting rid of
the crufty prompt-stack too!
Cheers
Phil
next prev parent reply other threads:[~2011-08-30 20:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 17:09 Phil Muldoon
2011-07-19 22:58 ` Tom Tromey
2011-07-20 13:05 ` Phil Muldoon
2011-07-20 14:43 ` Tom Tromey
2011-07-21 11:15 ` Phil Muldoon
2011-08-30 19:18 ` Pedro Alves
2011-08-30 20:23 ` Phil Muldoon [this message]
2011-08-30 20:18 ` Pedro Alves
2011-08-30 20:33 ` Phil Muldoon
2011-09-02 17:41 ` Pedro Alves
2011-09-03 10:15 ` Phil Muldoon
2011-07-20 17:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb4yr6no.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox