From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13370 invoked by alias); 30 Aug 2011 20:23:05 -0000 Received: (qmail 13361 invoked by uid 22791); 30 Aug 2011 20:23:03 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 20:22:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UKMa2b017008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 16:22:37 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7UKMZZW019170; Tue, 30 Aug 2011 16:22:35 -0400 From: Phil Muldoon To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [patch] [python] Prompt substitution References: <201108302018.03489.pedro@codesourcery.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Tue, 30 Aug 2011 20:23:00 -0000 In-Reply-To: <201108302018.03489.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 30 Aug 2011 20:18:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00633.txt.bz2 Pedro Alves writes: > I believe this to be a bit broken in the annotations (prefix and > suffix != NULL) case. If the observer changes the prompt, we won't print > either the prefix or the suffix, but will print directly what the > observer on the prompt itself only (get_prompt). Hmm, interesting. It passed the annotations tests :( > I believe it was not intended for the hook to be able > to override the prefix and the suffix as well. Right? > I'm fixing this along with the get-rid-of-prompt-stack > change. Nope, not intended to do anything at all with prefix/suffix. AFAIK prefix/suffix is only used in one particular case of annotations that matter (basically the control characters that are printed in the prefix/suffix when annotations > 1). Anyway, thanks for taking care of this. And thanks for getting rid of the crufty prompt-stack too! Cheers Phil