Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, pmuldoon@redhat.com
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] [python] Prompt substitution
Date: Tue, 30 Aug 2011 20:18:00 -0000	[thread overview]
Message-ID: <201108302118.18505.pedro@codesourcery.com> (raw)
In-Reply-To: <m362mxxk3f.fsf@redhat.com>

On Wednesday 20 July 2011 12:33:24, Phil Muldoon wrote:
> +gdb_test_multiple "set prompt blah " "set blah in GDB" {
> +    -re "\[\r\n\]$newprompt2 $" {
> +       pass "set prompt blah overriden"
> +    }
> +}
> +
> +gdb_test_multiple "python gdb.prompt_hook = None" "Delete hook" {
> +    -re "\[\r\n\]$newprompt2 $" {
> +       pass "Delete old hook"
> +    }
> +}

Hmm:

...
PASS: gdb.python/python.exp: show prompt shows guarded prompt
set prompt blah 
py prompt 2 PASS: gdb.python/python.exp: set prompt blah overriden
python gdb.prompt_hook = None
py prompt 2 PASS: gdb.python/python.exp: Delete old hook

I think this last PASS is actually a bug.  We've disabled the python
hook, so we should get the "set prompt" prompt back ("blah")
instead of still seeing the python prompt.  Agree?

(My WIP no-prompt-stack patch turned that into a FAIL,
but it looks like it's a bug fix, not a regression.)

-- 
Pedro Alves


  parent reply	other threads:[~2011-08-30 20:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 17:09 Phil Muldoon
2011-07-19 22:58 ` Tom Tromey
2011-07-20 13:05   ` Phil Muldoon
2011-07-20 14:43     ` Tom Tromey
2011-07-21 11:15       ` Phil Muldoon
2011-08-30 19:18     ` Pedro Alves
2011-08-30 20:23       ` Phil Muldoon
2011-08-30 20:18     ` Pedro Alves [this message]
2011-08-30 20:33       ` Phil Muldoon
2011-09-02 17:41         ` Pedro Alves
2011-09-03 10:15           ` Phil Muldoon
2011-07-20 17:10 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108302118.18505.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox