From: Eli Zaretskii <eliz@gnu.org>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] [python] Prompt substitution
Date: Wed, 20 Jul 2011 17:10:00 -0000 [thread overview]
Message-ID: <83pql4vqh5.fsf@gnu.org> (raw)
In-Reply-To: <m3oc0r1tjk.fsf@redhat.com>
> From: Phil Muldoon <pmuldoon@redhat.com>
> Date: Mon, 18 Jul 2011 16:45:51 +0100
>
> 2011-07-18 Phil Muldoon <pmuldoon@redhat.com>
>
> * observer.texi (GDB Observers): Add before_prompt observer.
> * gdb.texinfo (Basic Python): Add documentation for setting,
> getting and prompt substitution.
Thanks.
> +@defun set_current_prompt @r{[}new_prompt@r{]}
> +Sets the @value{GDBN} prompt to @var{new_prompt}.
^^^^
"Set", not "sets", to be consistent with the way we describe other
methods.
You don't say what is the effect of omitting new_prompt (which is
optional, according to the "[...]" syntax).
> +@defop Operation {@value{GDBN}} prompt_hook [current_prompt]
^^^^^^^^^^^^^^^^
You need @r{} here as well.
Also, what happens if current_prompt is omitted?
> +Called before a top-level prompt is displayed. @var{current_prompt} is
^^
Two spaces, please.
The documentation parts are okay with these comments.
prev parent reply other threads:[~2011-07-20 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 17:09 Phil Muldoon
2011-07-19 22:58 ` Tom Tromey
2011-07-20 13:05 ` Phil Muldoon
2011-07-20 14:43 ` Tom Tromey
2011-07-21 11:15 ` Phil Muldoon
2011-08-30 19:18 ` Pedro Alves
2011-08-30 20:23 ` Phil Muldoon
2011-08-30 20:18 ` Pedro Alves
2011-08-30 20:33 ` Phil Muldoon
2011-09-02 17:41 ` Pedro Alves
2011-09-03 10:15 ` Phil Muldoon
2011-07-20 17:10 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pql4vqh5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox